cc: Do solid color analysis before scheduling tiles.

cc/playback/display_list_raster_source.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/playback/display_list_raster_source.h"
 
 #include "base/trace_event/trace_event.h"
 #include "cc/base/region.h"
 #include "cc/debug/debug_colors.h"
 #include "cc/playback/display_item_list.h"
@@ skipping 199 matching lines @@
   return picture;
 }
 
 size_t DisplayListRasterSource::GetPictureMemoryUsage() const {
   if (!display_list_)
     return 0;
   return display_list_->ApproximateMemoryUsage() +
          painter_reported_memory_usage_;
 }
 
+bool DisplayListRasterSource::IsSolidColorTile(gfx::Rect content_rect,

[vmpstr, 2015/12/17 18:55:47]

Can you use PerformSolidColorAnalysis instead? That is, this function is way too
similar to it, so I don't think we should add it.

[sohanjg, 2015/12/18 12:50:00]

Yes, i thought we would remove PerformSolidColorAnalysis at a later patchset,
once we modify the tests.

Or you want to use PerformSolidColorAnalysis as function name here ?

[vmpstr, 2015/12/18 19:03:06]

I don't a rename, it's just this is the patch that should clean up other
instances. My thought is that we should actually use PerformSolidColorAnalysis
instead of this function. Note that the method for analyzing is slightly
different: this one does a scale on the matrix, the other one scales the rect to
analyze instead. I would prefer we keep the current approach to minimize
changes.

[sohanjg, 2015/12/29 14:29:47]

Acknowledged.

+                                               float scale,
+                                               SkColor* color) {
+  DCHECK(display_list_);
+
+  if (!display_list_->ShouldBeAnalyzedForSolidColor()) {
+    return false;
+  }
+
+  skia::AnalysisCanvas canvas(content_rect.width(), content_rect.height());
+  RasterForAnalysis(&canvas, content_rect, scale);
+  return canvas.GetColorIfSolid(color);
+}
+
 void DisplayListRasterSource::PerformSolidColorAnalysis(
     const gfx::Rect& content_rect,
     float contents_scale,
     DisplayListRasterSource::SolidColorAnalysis* analysis) const {
   DCHECK(analysis);
   TRACE_EVENT0("cc", "DisplayListRasterSource::PerformSolidColorAnalysis");
 
   gfx::Rect layer_rect =
       gfx::ScaleToEnclosingRect(content_rect, 1.0f / contents_scale);
 
@@ skipping 64 matching lines @@
 }
 
 scoped_refptr<DisplayListRasterSource>
 DisplayListRasterSource::CreateCloneWithoutLCDText() const {
   bool can_use_lcd_text = false;
   return scoped_refptr<DisplayListRasterSource>(
       new DisplayListRasterSource(this, can_use_lcd_text));
 }
 
 }  // namespace cc