Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 15310002: Identify data exports during split_link (Closed)

Created:
7 years, 7 months ago by scottmg
Modified:
7 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Identify data exports during split_link Generates proper .def files that include "DATA" so that non-functions are correctly exported. However, for split_link because the "other" side won't import them properly (__declspec(dllimport) is required) split_link notes them, and errors out. This also adds support for linking individual objs out of libs so that some _constants.cc and _switches.cc files can easily be linked into both DLLs. R=cpu@chromium.org BUG=237249 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=201119

Patch Set 1 #

Patch Set 2 : report data deps, since we don't have a good way to export them #

Patch Set 3 : . #

Patch Set 4 : ability to pull individual obj from lib #

Patch Set 5 : add some constants and switches to both sides via sub obj extraction #

Patch Set 6 : some more 'all' sub objs #

Patch Set 7 : error checking and a couple more objs #

Patch Set 8 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -2 lines) Patch
M build/split_link_partition.py View 1 2 3 4 5 6 7 1 chunk +45 lines, -0 lines 0 comments Download
M tools/win/split_link/split_link.py View 1 2 3 4 5 6 6 chunks +110 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
scottmg
7 years, 7 months ago (2013-05-18 04:20:42 UTC) #1
scottmg
Here's the current list: After https://codereview.chromium.org/15403002/ (almost?) all of them are just int or string ...
7 years, 7 months ago (2013-05-18 04:25:21 UTC) #2
scottmg
Another slightly crazy idea that might work for the constants: have the split linker find ...
7 years, 7 months ago (2013-05-19 02:27:02 UTC) #3
scottmg
Some more craziness, const variables don't export with __declspec(dllexport) or a .def file. e.g. these ...
7 years, 7 months ago (2013-05-19 02:43:57 UTC) #4
scottmg
Alright, continuing to talk to myself, I noticed that a lot of the constants are ...
7 years, 7 months ago (2013-05-19 04:58:32 UTC) #5
scottmg
This seems to work pretty well! I haven't found all the necessary _switches, _constants, etc. ...
7 years, 7 months ago (2013-05-19 05:43:02 UTC) #6
scottmg
Down to 50 remaining at patch set #6. There might be a handful more that ...
7 years, 7 months ago (2013-05-19 06:08:37 UTC) #7
scottmg
PTAL. With this CL, the number of data exports goes from 315 to this list ...
7 years, 7 months ago (2013-05-20 15:49:05 UTC) #8
cpu_(ooo_6.6-7.5)
lgtm
7 years, 7 months ago (2013-05-20 19:08:16 UTC) #9
scottmg
7 years, 7 months ago (2013-05-20 19:22:58 UTC) #10
Message was sent while issue was closed.
Committed patchset #8 manually as r201119 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698