Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(810)

Unified Diff: pkg/analyzer/lib/src/generated/element_resolver.dart

Issue 1530993002: Report HintCode.UNDEFINED_IDENTIFIER and HintCode.UNDEFINED_MEMBER for unresolved names in comments. Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/generated/error.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/element_resolver.dart
diff --git a/pkg/analyzer/lib/src/generated/element_resolver.dart b/pkg/analyzer/lib/src/generated/element_resolver.dart
index 06d0c56f3c979dec23e7620b6ac7a52a89b1e8a6..19f68d2e8c0ae3e5a0c8684304522f4add3d4ef0 100644
--- a/pkg/analyzer/lib/src/generated/element_resolver.dart
+++ b/pkg/analyzer/lib/src/generated/element_resolver.dart
@@ -217,6 +217,9 @@ class ElementResolver extends SimpleAstVisitor<Object> {
@override
Object visitCommentReference(CommentReference node) {
Identifier identifier = node.identifier;
+ if (identifier.isSynthetic) {
+ return null;
+ }
if (identifier is SimpleIdentifier) {
SimpleIdentifier simpleIdentifier = identifier;
Element element = _resolveSimpleIdentifier(simpleIdentifier);
@@ -232,11 +235,8 @@ class ElementResolver extends SimpleAstVisitor<Object> {
}
}
if (element == null) {
- // TODO(brianwilkerson) Report this error?
- // resolver.reportError(
- // StaticWarningCode.UNDEFINED_IDENTIFIER,
- // simpleIdentifier,
- // simpleIdentifier.getName());
+ _resolver.reportErrorForNode(HintCode.UNDEFINED_IDENTIFIER,
+ simpleIdentifier, [simpleIdentifier.name]);
} else {
if (element.library == null || element.library != _definingLibrary) {
// TODO(brianwilkerson) Report this error?
@@ -261,7 +261,8 @@ class ElementResolver extends SimpleAstVisitor<Object> {
SimpleIdentifier name = prefixedIdentifier.identifier;
Element element = _resolveSimpleIdentifier(prefix);
if (element == null) {
-// resolver.reportError(StaticWarningCode.UNDEFINED_IDENTIFIER, prefix, prefix.getName());
+ _resolver.reportErrorForNode(
+ HintCode.UNDEFINED_IDENTIFIER, prefix, [prefix.name]);
} else {
prefix.staticElement = element;
if (element is PrefixElement) {
@@ -290,7 +291,8 @@ class ElementResolver extends SimpleAstVisitor<Object> {
}
}
if (memberElement == null) {
-// reportGetterOrSetterNotFound(prefixedIdentifier, name, element.getDisplayName());
+ _resolver.reportErrorForNode(
+ HintCode.UNDEFINED_MEMBER, name, [name.name, prefix.name]);
} else {
name.staticElement = memberElement;
}
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/generated/error.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698