Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: gyp/common_conditions.gypi

Issue 153093003: Gyp file changes for the android framework. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gyp/common.gypi ('k') | gyp/common_variables.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gyp/common_conditions.gypi
diff --git a/gyp/common_conditions.gypi b/gyp/common_conditions.gypi
index 48a07b314b16b94a072b5f5879f80e8a91fa1a45..4db0a40358f7cd09fcd788486c695107f7e4fb73 100644
--- a/gyp/common_conditions.gypi
+++ b/gyp/common_conditions.gypi
@@ -193,28 +193,6 @@
},
],
- ['skia_android_framework', {
- 'cflags': [
- # Skia does not enforce this usage pattern so we disable it here to avoid
- # unecessary log spew when building
- '-Wno-unused-parameter',
-
- # Android's -D_FORTIFY_SOURCE=2 extensions are incompatibile with SkString.
- # Revert to -D_FORTIFY_SOURCE=1
- '-U_FORTIFY_SOURCE',
- '-D_FORTIFY_SOURCE=1',
- ],
- 'defines': [
- 'DCT_IFAST_SUPPORTED',
- # using freetype's embolden allows us to adjust fake bold settings at
- # draw-time, at which point we know which SkTypeface is being drawn
- 'SK_USE_FREETYPE_EMBOLDEN',
- # Android provides at least FreeType 2.4.0 at runtime.
- 'SK_FONTHOST_FREETYPE_RUNTIME_VERSION=0x020400',
- # Skia should not use dlopen on Android.
- 'SK_CAN_USE_DLOPEN=0',
- ],
- }],
[ 'skia_os in ["linux", "freebsd", "openbsd", "solaris", "nacl", "chromeos"]',
{
@@ -456,28 +434,18 @@
'SK_BUILD_FOR_ANDROID',
'SK_FONTHOST_DOES_NOT_USE_FONTMGR',
],
- 'conditions': [
- [ 'skia_android_framework==0', {
- # Don't use the configurations for skia_android_framework, where
- # we generate a single makefile for all builds, and flags can be
- # set manually for debugging.
- 'configurations': {
- 'Debug': {
- 'cflags': ['-g']
- },
- 'Release': {
- 'cflags': ['-O2'],
- 'defines': [ 'NDEBUG' ],
- },
- },
- # Adding these libraries is not necessary for the framework.
- 'libraries': [
- '-lstdc++',
- '-lm',
- ],
- }],
- ],
+ 'configurations': {
+ 'Debug': {
+ 'cflags': ['-g']
+ },
+ 'Release': {
+ 'cflags': ['-O2'],
+ 'defines': [ 'NDEBUG' ],
+ },
+ },
'libraries': [
+ '-lstdc++',
+ '-lm',
'-llog',
],
'cflags': [
« no previous file with comments | « gyp/common.gypi ('k') | gyp/common_variables.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698