Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Issue 1530893002: [proxies] Correctly handle proxies in Function.prototype.bind (Closed)

Created:
5 years ago by neis
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[proxies] Correctly handle proxies in Function.prototype.bind - Before getting the length property, we must check for it using [[GetOwnProperty]]. Also, if the obtained length is a number, we must properly convert it to an integer. - In order to get the prototype we must use [[GetPrototypeOf]], and do so before checking the length. R=cbruni@chromium.org, jkummerow@chromium.org BUG=v8:1543 LOG=n Committed: https://crrev.com/0d83aad55725f8c20fe050f06c37ff51ed773e8b Cr-Commit-Position: refs/heads/master@{#32934}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Also fix prototype handling. #

Patch Set 3 : Rebase and separate file for tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -18 lines) Patch
M src/js/v8natives.js View 1 2 chunks +13 lines, -12 lines 0 comments Download
M src/runtime/runtime.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-function.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M test/mjsunit/function-bind.js View 1 2 1 chunk +2 lines, -1 line 0 comments Download
A test/mjsunit/harmony/proxies-bind.js View 1 2 1 chunk +137 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
neis
5 years ago (2015-12-16 12:33:44 UTC) #1
Camillo Bruni
LGTM with more tests ;) https://codereview.chromium.org/1530893002/diff/1/test/mjsunit/function-bind.js File test/mjsunit/function-bind.js (right): https://codereview.chromium.org/1530893002/diff/1/test/mjsunit/function-bind.js#newcode355 test/mjsunit/function-bind.js:355: assertEquals(["apply", target, this_value, ["foo"]], ...
5 years ago (2015-12-16 13:19:07 UTC) #2
neis
https://codereview.chromium.org/1530893002/diff/1/test/mjsunit/function-bind.js File test/mjsunit/function-bind.js (right): https://codereview.chromium.org/1530893002/diff/1/test/mjsunit/function-bind.js#newcode355 test/mjsunit/function-bind.js:355: assertEquals(["apply", target, this_value, ["foo"]], log[3]); On 2015/12/16 13:19:06, cbruni ...
5 years ago (2015-12-16 14:00:24 UTC) #3
neis
On 2015/12/16 14:00:24, neis wrote: > https://codereview.chromium.org/1530893002/diff/1/test/mjsunit/function-bind.js > File test/mjsunit/function-bind.js (right): > > https://codereview.chromium.org/1530893002/diff/1/test/mjsunit/function-bind.js#newcode355 > ...
5 years ago (2015-12-16 14:58:09 UTC) #4
Camillo Bruni
lgtm
5 years ago (2015-12-16 14:59:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530893002/20001
5 years ago (2015-12-16 15:02:59 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9041)
5 years ago (2015-12-16 15:27:25 UTC) #14
Jakob Kummerow
This patch is also missing an entry in the Ignition test skip list. In fact, ...
5 years ago (2015-12-16 16:14:04 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530893002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530893002/40001
5 years ago (2015-12-17 08:31:56 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-12-17 09:07:19 UTC) #21
commit-bot: I haz the power
5 years ago (2015-12-17 09:08:08 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0d83aad55725f8c20fe050f06c37ff51ed773e8b
Cr-Commit-Position: refs/heads/master@{#32934}

Powered by Google App Engine
This is Rietveld 408576698