[proxies] Correctly handle proxies in Function.prototype.bind

[proxies] Correctly handle proxies in Function.prototype.bind

- Before getting the length property, we must check for it
  using [[GetOwnProperty]].  Also, if the obtained length
  is a number, we must properly convert it to an integer.

- In order to get the prototype we must use [[GetPrototypeOf]],
  and do so before checking the length.

R=cbruni@chromium.org, jkummerow@chromium.org
BUG=v8:1543
LOG=n

Committed: https://crrev.com/0d83aad55725f8c20fe050f06c37ff51ed773e8b
Cr-Commit-Position: refs/heads/master@{#32934}

[Camillo Bruni, 2015-12-16 13:19:07]

LGTM with more tests ;)

https://codereview.chromium.org/1530893002/diff/1/test/mjsunit/function-bind.js
File test/mjsunit/function-bind.js (right):

https://codereview.chromium.org/1530893002/diff/1/test/mjsunit/function-bind....
test/mjsunit/function-bind.js:355: assertEquals(["apply", target, this_value,
["foo"]], log[3]);
Could you add another test where you check the log for GetPrototypeOf call in
9.4.1.3 BoundFunctionCreate (just make sure we totally respect the order of all
these calls)?

And you might need another test with a Constructable proxy (again 9.4.1.3)?

[neis, 2015-12-16 14:00:24]

https://codereview.chromium.org/1530893002/diff/1/test/mjsunit/function-bind.js
File test/mjsunit/function-bind.js (right):

https://codereview.chromium.org/1530893002/diff/1/test/mjsunit/function-bind....
test/mjsunit/function-bind.js:355: assertEquals(["apply", target, this_value,
["foo"]], log[3]);
On 2015/12/16 13:19:06, cbruni wrote:
> Could you add another test where you check the log for GetPrototypeOf call in
> 9.4.1.3 BoundFunctionCreate (just make sure we totally respect the order of
all
> these calls)?
> 
> And you might need another test with a Constructable proxy (again 9.4.1.3)?

As discussed, the getPrototypeOf should already have shown up here, so the
implementation of BoundFunctionCreate is indeed wrong as well.  Will update the
CL.

[neis, 2015-12-16 14:58:09]

On 2015/12/16 14:00:24, neis wrote:
>
https://codereview.chromium.org/1530893002/diff/1/test/mjsunit/function-bind.js
> File test/mjsunit/function-bind.js (right):
> 
>
https://codereview.chromium.org/1530893002/diff/1/test/mjsunit/function-bind....
> test/mjsunit/function-bind.js:355: assertEquals(["apply", target, this_value,
> ["foo"]], log[3]);
> On 2015/12/16 13:19:06, cbruni wrote:
> > Could you add another test where you check the log for GetPrototypeOf call
in
> > 9.4.1.3 BoundFunctionCreate (just make sure we totally respect the order of
> all
> > these calls)?
> > 
> > And you might need another test with a Constructable proxy (again 9.4.1.3)?
> 
> As discussed, the getPrototypeOf should already have shown up here, so the
> implementation of BoundFunctionCreate is indeed wrong as well.  Will update
the
> CL.

Ok, uploaded new patch set.

[Camillo Bruni, 2015-12-16 14:59:54]

lgtm

[neis, 2015-12-16 15:00:50]

Description was changed from

==========
[proxies] Correctly deal with function length in Function.prototype.bind

Before getting the length property, we must check for it using
[[GetOwnProperty]].  Also, if the obtained length is a number, we must properly
convert it to an integer.

R=cbruni@chromium.org, jkummerow@chromium.org
BUG=
==========

to

==========
[proxies] Correctly deal with proxies in Function.prototype.bind

- Before getting the length property, we must check for it using
[[GetOwnProperty]].  Also, if the obtained length is a number, we must properly
convert it to an integer.

- In order to get the prototype we must use [[GetPrototypeOf]].

R=cbruni@chromium.org, jkummerow@chromium.org
BUG=
==========

[neis, 2015-12-16 15:01:25]

Description was changed from

==========
[proxies] Correctly deal with proxies in Function.prototype.bind

- Before getting the length property, we must check for it using
[[GetOwnProperty]].  Also, if the obtained length is a number, we must properly
convert it to an integer.

- In order to get the prototype we must use [[GetPrototypeOf]].

R=cbruni@chromium.org, jkummerow@chromium.org
BUG=
==========

to

==========
[proxies] Correctly deal with proxies in Function.prototype.bind

- Before getting the length property, we must check for it
  using [[GetOwnProperty]].  Also, if the obtained length
  is a number, we must properly convert it to an integer.

- In order to get the prototype we must use [[GetPrototypeOf]].

R=cbruni@chromium.org, jkummerow@chromium.org
BUG=
==========

[neis, 2015-12-16 15:01:44]

Description was changed from

==========
[proxies] Correctly deal with proxies in Function.prototype.bind

- Before getting the length property, we must check for it
  using [[GetOwnProperty]].  Also, if the obtained length
  is a number, we must properly convert it to an integer.

- In order to get the prototype we must use [[GetPrototypeOf]].

R=cbruni@chromium.org, jkummerow@chromium.org
BUG=
==========

to

==========
[proxies] Correctly handle proxies in Function.prototype.bind

- Before getting the length property, we must check for it
  using [[GetOwnProperty]].  Also, if the obtained length
  is a number, we must properly convert it to an integer.

- In order to get the prototype we must use [[GetPrototypeOf]].

R=cbruni@chromium.org, jkummerow@chromium.org
BUG=
==========

[neis, 2015-12-16 15:02:20]

Description was changed from

==========
[proxies] Correctly handle proxies in Function.prototype.bind

- Before getting the length property, we must check for it
  using [[GetOwnProperty]].  Also, if the obtained length
  is a number, we must properly convert it to an integer.

- In order to get the prototype we must use [[GetPrototypeOf]].

R=cbruni@chromium.org, jkummerow@chromium.org
BUG=
==========

to

==========
[proxies] Correctly handle proxies in Function.prototype.bind

- Before getting the length property, we must check for it
  using [[GetOwnProperty]].  Also, if the obtained length
  is a number, we must properly convert it to an integer.

- In order to get the prototype we must use [[GetPrototypeOf]], and do so before
checking the length.

R=cbruni@chromium.org, jkummerow@chromium.org
BUG=
==========

[neis, 2015-12-16 15:02:31]

Description was changed from

==========
[proxies] Correctly handle proxies in Function.prototype.bind

- Before getting the length property, we must check for it
  using [[GetOwnProperty]].  Also, if the obtained length
  is a number, we must properly convert it to an integer.

- In order to get the prototype we must use [[GetPrototypeOf]], and do so before
checking the length.

R=cbruni@chromium.org, jkummerow@chromium.org
BUG=
==========

to

==========
[proxies] Correctly handle proxies in Function.prototype.bind

- Before getting the length property, we must check for it
  using [[GetOwnProperty]].  Also, if the obtained length
  is a number, we must properly convert it to an integer.

- In order to get the prototype we must use [[GetPrototypeOf]],
  and do so before checking the length.

R=cbruni@chromium.org, jkummerow@chromium.org
BUG=
==========

[neis, 2015-12-16 15:02:47]

The CQ bit was checked by neis@chromium.org

[commit-bot: I haz the power, 2015-12-16 15:02:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530893002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530893002/20001

[commit-bot: I haz the power, 2015-12-16 15:27:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-16 15:27:25]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9041)

[Jakob Kummerow, 2015-12-16 16:14:04]

This patch is also missing an entry in the Ignition test skip list.

In fact, I'd prefer adding the new test as a separate file
mjsunit/harmony/proxies-function-bind.js, so the existing function-bind.js
doesn't need any --harmony-* flags. (Also, smaller test files are nice.)

So LGTM if you move the test (and skip it for Ignition).

[neis, 2015-12-17 08:23:13]

The CQ bit was checked by neis@chromium.org

[neis, 2015-12-17 08:23:13]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org,
jkummerow@chromium.org
Link to the patchset: https://codereview.chromium.org/1530893002/#ps40001
(title: "Rebase and separate file for tests.")

[commit-bot: I haz the power, 2015-12-17 08:31:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530893002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530893002/40001

[neis, 2015-12-17 08:58:28]

Description was changed from

==========
[proxies] Correctly handle proxies in Function.prototype.bind

- Before getting the length property, we must check for it
  using [[GetOwnProperty]].  Also, if the obtained length
  is a number, we must properly convert it to an integer.

- In order to get the prototype we must use [[GetPrototypeOf]],
  and do so before checking the length.

R=cbruni@chromium.org, jkummerow@chromium.org
BUG=
==========

to

==========
[proxies] Correctly handle proxies in Function.prototype.bind

- Before getting the length property, we must check for it
  using [[GetOwnProperty]].  Also, if the obtained length
  is a number, we must properly convert it to an integer.

- In order to get the prototype we must use [[GetPrototypeOf]],
  and do so before checking the length.

R=cbruni@chromium.org, jkummerow@chromium.org
BUG=v8:1543
LOG=n
==========

[commit-bot: I haz the power, 2015-12-17 09:07:19]

Description was changed from

==========
[proxies] Correctly handle proxies in Function.prototype.bind

- Before getting the length property, we must check for it
  using [[GetOwnProperty]].  Also, if the obtained length
  is a number, we must properly convert it to an integer.

- In order to get the prototype we must use [[GetPrototypeOf]],
  and do so before checking the length.

R=cbruni@chromium.org, jkummerow@chromium.org
BUG=v8:1543
LOG=n
==========

to

==========
[proxies] Correctly handle proxies in Function.prototype.bind

- Before getting the length property, we must check for it
  using [[GetOwnProperty]].  Also, if the obtained length
  is a number, we must properly convert it to an integer.

- In order to get the prototype we must use [[GetPrototypeOf]],
  and do so before checking the length.

R=cbruni@chromium.org, jkummerow@chromium.org
BUG=v8:1543
LOG=n
==========

[commit-bot: I haz the power, 2015-12-17 09:07:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-17 09:08:07]

Description was changed from

==========
[proxies] Correctly handle proxies in Function.prototype.bind

- Before getting the length property, we must check for it
  using [[GetOwnProperty]].  Also, if the obtained length
  is a number, we must properly convert it to an integer.

- In order to get the prototype we must use [[GetPrototypeOf]],
  and do so before checking the length.

R=cbruni@chromium.org, jkummerow@chromium.org
BUG=v8:1543
LOG=n
==========

to

==========
[proxies] Correctly handle proxies in Function.prototype.bind

- Before getting the length property, we must check for it
  using [[GetOwnProperty]].  Also, if the obtained length
  is a number, we must properly convert it to an integer.

- In order to get the prototype we must use [[GetPrototypeOf]],
  and do so before checking the length.

R=cbruni@chromium.org, jkummerow@chromium.org
BUG=v8:1543
LOG=n

Committed: https://crrev.com/0d83aad55725f8c20fe050f06c37ff51ed773e8b
Cr-Commit-Position: refs/heads/master@{#32934}
==========

[commit-bot: I haz the power, 2015-12-17 09:08:08]

Patchset 3 (id:??) landed as
https://crrev.com/0d83aad55725f8c20fe050f06c37ff51ed773e8b
Cr-Commit-Position: refs/heads/master@{#32934}