Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1530873002: [proxies] Fix bogus cast in HasOwnPropertyImplementation (Closed)

Created:
5 years ago by Jakob Kummerow
Modified:
5 years ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[proxies] Fix bogus cast in HasOwnPropertyImplementation BUG=v8:1543, chromium:570120 LOG=n Committed: https://crrev.com/35e5b6824ed16aa3ea230fcd9ec98548e95ba986 Cr-Commit-Position: refs/heads/master@{#32892}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M src/runtime/runtime-object.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M test/mjsunit/harmony/proxies-has.js View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jakob Kummerow
5 years ago (2015-12-16 10:47:58 UTC) #2
Camillo Bruni
lgtm
5 years ago (2015-12-16 11:22:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530873002/1
5 years ago (2015-12-16 11:23:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 11:42:01 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-16 11:42:53 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/35e5b6824ed16aa3ea230fcd9ec98548e95ba986
Cr-Commit-Position: refs/heads/master@{#32892}

Powered by Google App Engine
This is Rietveld 408576698