chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api_stub.cc - Issue 1530863002: Allow audio debug recordings through a private API extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api_stub.cc

Issue 1530863002: Allow audio debug recordings through a private API extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Callback updates tommi's comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc ('K') | « chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api.cc ('k') | chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_apitest.cc » ('j') | chrome/browser/resources/hangout_services/thunk.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api_stub.cc

diff --git a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api_stub.cc b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api_stub.cc

index 836e06b19b73528bc7e4064a3364d2cb0134f5ec..05b81b427bab9e219808335930a0f4ecf6c2e086 100644

--- a/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api_stub.cc

+++ b/chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api_stub.cc

@@ -74,4 +74,16 @@ bool WebrtcLoggingPrivateStopRtpDumpFunction::RunAsync() {

return false;

}

+bool WebrtcLoggingPrivateStartAecDumpFunction::RunAsync() {

+ SetError(kErrorNotSupported);

+ SendResponse(false);

+ return false;

+bool WebrtcLoggingPrivateStopAecDumpFunction::RunAsync() {

+ SetError(kErrorNotSupported);

+ SendResponse(false);

+ return false;

} // namespace extensions