Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6000)

Unified Diff: chrome/common/extensions/api/webrtc_logging_private.idl

Issue 1530863002: Allow audio debug recordings through a private API extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/webrtc_logging_private.idl
diff --git a/chrome/common/extensions/api/webrtc_logging_private.idl b/chrome/common/extensions/api/webrtc_logging_private.idl
index 5c72c9597ba15e33f52a02f2644256eb8bcc9772..12c47e9efd7c3abcf7a731e8820d57d92d6daa4e 100644
--- a/chrome/common/extensions/api/webrtc_logging_private.idl
+++ b/chrome/common/extensions/api/webrtc_logging_private.idl
@@ -28,7 +28,14 @@ namespace webrtcLoggingPrivate {
long? guestProcessId;
};
+ dictionary AecDumpInfo {
+ // Absolute path prefix for the AEC dump. Empty if not successful.
+ DOMString prefixPath;
+ };
+
+
callback GenericDoneCallback = void ();
+ callback AecDumpStartedCallback = void (AecDumpInfo info);
callback UploadDoneCallback = void (UploadResult result);
interface Functions {
@@ -111,5 +118,18 @@ namespace webrtcLoggingPrivate {
boolean incoming,
boolean outgoing,
GenericDoneCallback callback);
+
+ // Starts an AEC Dump for all renderer processes with open peer connections.
+ // One file per renderer process will be created, with the renderer
+ // process ID appended to a predefined file path.
+ // |seconds| indicates how many seconds of audio to record. If |seconds|
+ // is zero, recording will continue until stopAecDump() is explicitly called.
tommi (sloooow) - chröme 2015/12/17 11:03:26 >80
Guido Urdaneta 2015/12/17 14:35:42 Done.
+ // If |seconds| is negative, startAecDump() will fail.
+ // The base filename for dumps is returned to |callback|.
+ static void startAecDump(long seconds, AecDumpStartedCallback callback);
+ //static void startAecDump(optional long seconds, [Default=Undefined] optional GenericDoneCallback callback);
tommi (sloooow) - chröme 2015/12/17 11:03:26 remove?
Guido Urdaneta 2015/12/17 14:35:42 Done.
+
+ // Stops all AEC Dumps for all renderer processes.
+ static void stopAecDump(GenericDoneCallback callback);
};
};

Powered by Google App Engine
This is Rietveld 408576698