Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Unified Diff: third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.h

Issue 1530853002: Split up text painting code into separate functions to setup paint and then paint text. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: If we can't setup paint don't paint text with default paint Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.h
diff --git a/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.h b/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.h
index cc82684429860350af6e2cbe426305e6195ef218..052e0dbab94199c98c726746fa60fc284ef246d5 100644
--- a/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.h
+++ b/third_party/WebKit/Source/core/paint/SVGInlineTextBoxPainter.h
@@ -34,7 +34,8 @@ private:
bool shouldPaintSelection(const PaintInfo&) const;
void paintTextFragments(const PaintInfo&, LayoutObject&);
void paintDecoration(const PaintInfo&, TextDecoration, const SVGTextFragment&);
- void paintTextWithShadows(const PaintInfo&, const ComputedStyle&, TextRun&, const SVGTextFragment&, int startPosition, int endPosition, LayoutSVGResourceMode);
+ bool setupTextPaint(const PaintInfo&, const ComputedStyle&, TextRun&, const SVGTextFragment&, LayoutSVGResourceMode, SkPaint&);
+ void paintText(const PaintInfo&, TextRun&, const SVGTextFragment&, int startPosition, int endPosition, SkPaint&);
void paintText(const PaintInfo&, const ComputedStyle&, const ComputedStyle& selectionStyle, const SVGTextFragment&, LayoutSVGResourceMode, bool shouldPaintSelection);
const SVGInlineTextBox& m_svgInlineTextBox;

Powered by Google App Engine
This is Rietveld 408576698