add fsync to try to get complete skps from webpage picture capture

add fsync to try to get complete skps from webpage picture capture

R=reed@google.com,mtklein@google.com
BUG=skia:4691
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1530783003

Committed: https://skia.googlesource.com/skia/+/7471fa4920a3573afcf6e2d94722e73d3d9b12a7

[caryclark, 2015-12-16 14:57:47]

Description was changed from

==========
add fsync to try to get complete skps from webpage picture capture

R=reed@google.com,mtklein@google.com
BUG=skia:4691
==========

to

==========
add fsync to try to get complete skps from webpage picture capture

R=reed@google.com,mtklein@google.com
BUG=skia:4691
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[caryclark, 2015-12-16 14:58:37]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-16 14:58:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530783003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530783003/1

[commit-bot: I haz the power, 2015-12-16 14:59:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-16 14:59:38]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)

[caryclark, 2015-12-16 15:13:12]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-16 15:13:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530783003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530783003/20001

[caryclark, 2015-12-16 15:21:17]

PTAL

[reed1, 2015-12-16 15:26:36]

reed@google.com changed reviewers:
+ bungeman@google.com

[reed1, 2015-12-16 15:26:36]

is it ever risky to call fsync w/o calling fflush first?

I think we should add some (modest) dox in SkWStream.h now that we're exposing
flush and sync

[commit-bot: I haz the power, 2015-12-16 15:27:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-16 15:27:39]

Dry run: This issue passed the CQ dry run.

[mtklein, 2015-12-16 15:30:09]

mtklein@google.com changed reviewers:
- bungeman@google.com

[mtklein, 2015-12-16 15:30:10]

lgtm

https://codereview.chromium.org/1530783003/diff/20001/src/ports/SkOSFile_stdi...
File src/ports/SkOSFile_stdio.cpp (right):

https://codereview.chromium.org/1530783003/diff/20001/src/ports/SkOSFile_stdi...
src/ports/SkOSFile_stdio.cpp:148: #if !defined(_WIN32) &&
!defined(SK_BUILD_FOR_ANDROID) && !defined(__UCLIBC__) \
If we want to try Windows too, I think it's something like
   FlushFileBuffers((HANDLE)_get_osfhandle(_fileno(f)));

[caryclark, 2015-12-16 16:03:22]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-12-16 16:03:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530783003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530783003/40001

[commit-bot: I haz the power, 2015-12-16 16:25:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-16 16:25:21]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2015-12-16 17:19:05]

Are we not building SkOSFile_posix.cpp on Android? It uses fileno . Are you sure
it's not just a missing header (SkOSFile_stdio.cpp shouldn't have posix headers
included), and since Windows (as usual) does things differently, should the
fsync call be done in SkOSFile_posix.cpp, with for now and implementation in
SkOSFile_win.cpp which does nothing (so it's obvious it needs to be
implemented)?

[caryclark, 2015-12-16 18:40:31]

The CQ bit was checked by caryclark@google.com

[caryclark, 2015-12-16 18:40:31]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1530783003/#ps40001
(title: "make sync nonvirtual")

[commit-bot: I haz the power, 2015-12-16 18:40:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530783003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530783003/40001

[commit-bot: I haz the power, 2015-12-16 18:41:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-16 18:41:54]

Try jobs failed on following builders:
  skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED,
http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/bu...)

[reed1, 2015-12-16 21:40:25]

The CQ bit was checked by reed@google.com

[reed1, 2015-12-16 21:40:26]

lgtm

[commit-bot: I haz the power, 2015-12-16 21:40:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530783003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530783003/40001

[commit-bot: I haz the power, 2015-12-16 21:41:26]

Description was changed from

==========
add fsync to try to get complete skps from webpage picture capture

R=reed@google.com,mtklein@google.com
BUG=skia:4691
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
add fsync to try to get complete skps from webpage picture capture

R=reed@google.com,mtklein@google.com
BUG=skia:4691
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/7471fa4920a3573afcf6e2d94722e73d3d9b12a7
==========

[commit-bot: I haz the power, 2015-12-16 21:41:27]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/7471fa4920a3573afcf6e2d94722e73d3d9b12a7