Chromium Code Reviews
DescriptionRevert of Fix flaky logo spin animation restart logic (patchset #1 id:1 of https://codereview.chromium.org/1525953002/ )
Reason for revert:
Broke the closure compiler.
http://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux/builds/42544/steps/compile/logs/stdio
ERROR - Suspicious code. The result of the 'getprop' operator is not being used.
## getComputedStyle(logo).animationName;
## ^
##
Original issue's description:
> Fix flaky logo spin animation restart logic
>
> This change updates the click handler for the Chrome logo in the help
> page to force a style recalc between removing the "spin" class and
> adding it back again. This ensures that any running animations are
> cancelled and a new animation starts.
>
> Previously the code was relying on setTimeout() to wait for a style
> recalc which was never guaranteed thus the animation would not always
> restart.
>
> BUG=568485
>
> Committed: https://crrev.com/b1bad612c1806c51985dd1b5220b053882ab21f0
> Cr-Commit-Position: refs/heads/master@{#365242}
TBR=samli@chromium.org,bauerb@chromium.org,dbeam@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=568485
Committed: https://crrev.com/7808056191dfceea82927b2ae89a2a837d19fbb2
Cr-Commit-Position: refs/heads/master@{#365380}
Patch Set 1 #
Messages
Total messages: 5 (1 generated)
|
|||||||||||||||||||