Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1530773002: Revert of Fix flaky logo spin animation restart logic (Closed)

Created:
5 years ago by alancutter (OOO until 2018)
Modified:
5 years ago
CC:
arv+watch_chromium.org, chromium-reviews, dstockwell, loyso (OOO), samli, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix flaky logo spin animation restart logic (patchset #1 id:1 of https://codereview.chromium.org/1525953002/ ) Reason for revert: Broke the closure compiler. http://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux/builds/42544/steps/compile/logs/stdio ERROR - Suspicious code. The result of the 'getprop' operator is not being used. ## getComputedStyle(logo).animationName; ## ^ ## Original issue's description: > Fix flaky logo spin animation restart logic > > This change updates the click handler for the Chrome logo in the help > page to force a style recalc between removing the "spin" class and > adding it back again. This ensures that any running animations are > cancelled and a new animation starts. > > Previously the code was relying on setTimeout() to wait for a style > recalc which was never guaranteed thus the animation would not always > restart. > > BUG=568485 > > Committed: https://crrev.com/b1bad612c1806c51985dd1b5220b053882ab21f0 > Cr-Commit-Position: refs/heads/master@{#365242} TBR=samli@chromium.org,bauerb@chromium.org,dbeam@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=568485 Committed: https://crrev.com/7808056191dfceea82927b2ae89a2a837d19fbb2 Cr-Commit-Position: refs/heads/master@{#365380}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/browser/resources/help/help_page.js View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
alancutter (OOO until 2018)
Created Revert of Fix flaky logo spin animation restart logic
5 years ago (2015-12-15 23:14:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530773002/1
5 years ago (2015-12-15 23:16:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 23:21:18 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-15 23:22:22 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7808056191dfceea82927b2ae89a2a837d19fbb2
Cr-Commit-Position: refs/heads/master@{#365380}

Powered by Google App Engine
This is Rietveld 408576698