chrome/browser/supervised_user/supervised_user_settings_service.cc - Issue 1530763004: Add Statistics for SupervisedUserSettingService during merging and syncing data.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/supervised_user/supervised_user_settings_service.cc

Issue 1530763004: Add Statistics for SupervisedUserSettingService during merging and syncing data. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/supervised_user/legacy/supervised_user_shared_settings_service.cc ('K') | « chrome/browser/supervised_user/legacy/supervised_user_shared_settings_service.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/supervised_user/supervised_user_settings_service.cc

diff --git a/chrome/browser/supervised_user/supervised_user_settings_service.cc b/chrome/browser/supervised_user/supervised_user_settings_service.cc

index db09106b4e5df4dd6792f75746f69d280395fa07..96c27b61494631101e4ae3edb3f39e4f2b3665bf 100644

--- a/chrome/browser/supervised_user/supervised_user_settings_service.cc

+++ b/chrome/browser/supervised_user/supervised_user_settings_service.cc

@@ -10,6 +10,7 @@

#include "base/callback.h"

#include "base/json/json_reader.h"

#include "base/json/json_writer.h"

+#include "base/metrics/histogram.h"

#include "base/prefs/json_pref_store.h"

#include "base/prefs/pref_filter.h"

#include "base/strings/string_util.h"

@@ -237,7 +238,9 @@ SyncMergeResult SupervisedUserSettingsService::MergeDataAndStartSyncing(

sync_processor_->ProcessSyncChanges(FROM_HERE, change_list));

}

- // TODO(bauerb): Statistics?

+ UMA_HISTOGRAM_ENUMERATION("SupervisedUserSettingService.SyncMergeResult",

+ result.model_type(), syncer::MODEL_TYPE_COUNT);

return result;

}