Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 153073002: Use stricter typing for traverse roots in SelectorQuery (Closed)

Created:
6 years, 10 months ago by Inactive
Modified:
6 years, 10 months ago
Reviewers:
esprehn, adamk
CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use stricter typing for traverse roots in SelectorQuery Use stricter typing for traverse roots in SelectorQuery. We now use Element or ContainerNode, as appropriate. This enables using the faster DOM traversal method specializations as the compiler now knows these are container nodes and not simply generic Node types. R=esprehn, adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166344

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -13 lines) Patch
M Source/core/dom/SelectorQuery.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/SelectorQuery.cpp View 4 chunks +8 lines, -10 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Inactive
6 years, 10 months ago (2014-02-03 21:59:23 UTC) #1
adamk
lgtm
6 years, 10 months ago (2014-02-03 22:15:59 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-03 22:27:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/153073002/1
6 years, 10 months ago (2014-02-03 22:28:23 UTC) #4
commit-bot: I haz the power
Change committed as 166344
6 years, 10 months ago (2014-02-04 00:44:46 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 00:44:48 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 00:44:51 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 00:44:53 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 00:44:53 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-04 00:45:48 UTC) #10
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698