third_party/WebKit/Source/platform/graphics/filters/SpotLightSource.h - Issue 1530723004: Use clampTo instead of chaining std::max(std::min(...))

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/SpotLightSource.h

Issue 1530723004: Use clampTo instead of chaining std::max(std::min(...)) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/filters/FESpecularLighting.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/SpotLightSource.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/SpotLightSource.h

diff --git a/third_party/WebKit/Source/platform/graphics/filters/SpotLightSource.h b/third_party/WebKit/Source/platform/graphics/filters/SpotLightSource.h

index 6de25ff59168423d5a8fb24ceeaf1fdc58d6914d..e00546072bd35ad48e924e0c2f338fc0e11fb5b3 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/SpotLightSource.h

+++ b/third_party/WebKit/Source/platform/graphics/filters/SpotLightSource.h

@@ -24,7 +24,7 @@

#define SpotLightSource_h

#include "platform/graphics/filters/LightSource.h"

-#include <algorithm>

+#include "wtf/MathExtras.h"

namespace blink {

@@ -55,7 +55,7 @@ private:

: LightSource(LS_SPOT)

, m_position(position)

, m_direction(direction)

- , m_specularExponent(std::min(std::max(specularExponent, 1.0f), 128.0f))

+ , m_specularExponent(clampTo(specularExponent, 1.0f, 128.0f))

, m_limitingConeAngle(limitingConeAngle)

{

}