third_party/WebKit/Source/platform/audio/EqualPowerPanner.cpp - Issue 1530723004: Use clampTo instead of chaining std::max(std::min(...))

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/audio/EqualPowerPanner.cpp

Issue 1530723004: Use clampTo instead of chaining std::max(std::min(...)) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More rebase Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/audio/DynamicsCompressorKernel.cpp ('k') | third_party/WebKit/Source/platform/audio/HRTFDatabase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/audio/EqualPowerPanner.cpp

diff --git a/third_party/WebKit/Source/platform/audio/EqualPowerPanner.cpp b/third_party/WebKit/Source/platform/audio/EqualPowerPanner.cpp

index 9d55691c7e01dfe34c953b02d8dbc41ae6e14319..fafe8328e1e48cbccdf6ceee752c7cd5a62540dc 100644

--- a/third_party/WebKit/Source/platform/audio/EqualPowerPanner.cpp

+++ b/third_party/WebKit/Source/platform/audio/EqualPowerPanner.cpp

@@ -25,10 +25,11 @@

#include "platform/audio/EqualPowerPanner.h"

#if ENABLE(WEB_AUDIO)

-#include <algorithm>

#include "platform/audio/AudioBus.h"

#include "platform/audio/AudioUtilities.h"

#include "wtf/MathExtras.h"

+#include <algorithm>

+#include <cmath>

// Use a 50ms smoothing / de-zippering time-constant.

const float SmoothingTimeConstant = 0.050f;

@@ -67,8 +68,7 @@ void EqualPowerPanner::pan(double azimuth, double /*elevation*/, const AudioBus*

return;

// Clamp azimuth to allowed range of -180 -> +180.

- azimuth = std::max(-180.0, azimuth);

- azimuth = std::min(180.0, azimuth);

+ azimuth = clampTo(azimuth, -180.0, 180.0);

// Alias the azimuth ranges behind us to in front of us:

// -90 -> -180 to -90 -> 0 and 90 -> 180 to 90 -> 0