third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.cpp - Issue 1530723004: Use clampTo instead of chaining std::max(std::min(...))

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.cpp

Issue 1530723004: Use clampTo instead of chaining std::max(std::min(...)) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Handling that minimumThumbLength > trackLen. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/audio/HRTFKernel.cpp ('K') | « third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm ('k') | third_party/WebKit/Source/platform/scroll/ScrollableArea.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.cpp

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.cpp b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.cpp

index da2a57cb3a310086ac2aa05ddc692e370475ac9a..5859d80fa18ebe18087bda00e25376cc9055b0b4 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.cpp

+++ b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorBase.cpp

@@ -34,8 +34,8 @@

#include "platform/RuntimeEnabledFeatures.h"

#include "platform/geometry/FloatPoint.h"

#include "platform/scroll/ScrollableArea.h"

+#include "wtf/MathExtras.h"

#include "wtf/PassOwnPtr.h"

-#include <algorithm>

namespace blink {

@@ -99,7 +99,7 @@ float ScrollAnimatorBase::clampScrollPosition(ScrollbarOrientation orientation,

{

float maxScrollPos = m_scrollableArea->maximumScrollPosition(orientation);

float minScrollPos = m_scrollableArea->minimumScrollPosition(orientation);

- return std::max(std::min(pos, maxScrollPos), minScrollPos);

+ return clampTo(pos, minScrollPos, maxScrollPos);

}

DEFINE_TRACE(ScrollAnimatorBase)