third_party/WebKit/Source/platform/graphics/filters/FESpecularLighting.cpp - Issue 1530723004: Use clampTo instead of chaining std::max(std::min(...))

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FESpecularLighting.cpp

Issue 1530723004: Use clampTo instead of chaining std::max(std::min(...)) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Handling that minimumThumbLength > trackLen. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/audio/HRTFKernel.cpp ('K') | « third_party/WebKit/Source/platform/graphics/filters/FELighting.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/SpotLightSource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FESpecularLighting.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FESpecularLighting.cpp b/third_party/WebKit/Source/platform/graphics/filters/FESpecularLighting.cpp

index b4b39609f6d92d773f29cdd0d6ef19eef9305434..372e90c46befcc06052406e9c9927f578ac79416 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FESpecularLighting.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FESpecularLighting.cpp

@@ -25,6 +25,8 @@

#include "platform/graphics/filters/LightSource.h"

#include "platform/text/TextStream.h"

+#include "wtf/MathExtras.h"

+#include <algorithm>

namespace blink {

@@ -92,7 +94,7 @@ float FESpecularLighting::specularExponent() const

bool FESpecularLighting::setSpecularExponent(float specularExponent)

{

- specularExponent = std::min(std::max(specularExponent, 1.0f), 128.0f);

+ specularExponent = clampTo(specularExponent, 1.0f, 128.0f);

if (m_specularExponent == specularExponent)

return false;

m_specularExponent = specularExponent;