third_party/WebKit/Source/platform/audio/VectorMath.cpp - Issue 1530723004: Use clampTo instead of chaining std::max(std::min(...))

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/audio/VectorMath.cpp

Issue 1530723004: Use clampTo instead of chaining std::max(std::min(...)) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Handling that minimumThumbLength > trackLen. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/audio/HRTFKernel.cpp ('K') | « third_party/WebKit/Source/platform/audio/HRTFPanner.cpp ('k') | third_party/WebKit/Source/platform/graphics/Color.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/audio/VectorMath.cpp

diff --git a/third_party/WebKit/Source/platform/audio/VectorMath.cpp b/third_party/WebKit/Source/platform/audio/VectorMath.cpp

index 219ed5463977ac5cc172f1117fd0cca3f9008a9a..e83430a95d8c0ec249d81e870a233969234b9043 100644

--- a/third_party/WebKit/Source/platform/audio/VectorMath.cpp

+++ b/third_party/WebKit/Source/platform/audio/VectorMath.cpp

@@ -29,6 +29,7 @@

#include "platform/audio/VectorMath.h"

#include "wtf/Assertions.h"

#include "wtf/CPU.h"

+#include "wtf/MathExtras.h"

#include <stdint.h>

#if OS(MACOSX)

@@ -675,7 +676,7 @@ void vclip(const float* sourceP, int sourceStride, const float* lowThresholdP, c

}

#endif

while (n--) {

- *destP = std::max(std::min(*sourceP, highThreshold), lowThreshold);

+ *destP = clampTo(*sourceP, lowThreshold, highThreshold);

sourceP += sourceStride;

destP += destStride;

}