Adding location events to the histogram

chrome/browser/resources/google_now/background.js

Index: chrome/browser/resources/google_now/background.js
diff --git a/chrome/browser/resources/google_now/background.js b/chrome/browser/resources/google_now/background.js
index 0fdbd6724c10e7292d530e9fbf3dc12adacdf8ec..d2790a17c22d7a0cd1dd33c80b53effefd093102 100644
--- a/chrome/browser/resources/google_now/background.js
+++ b/chrome/browser/resources/google_now/background.js
@@ -141,7 +141,9 @@ var DiagnosticEvent = {
   CARDS_PARSE_SUCCESS: 2,
   DISMISS_REQUEST_TOTAL: 3,
   DISMISS_REQUEST_SUCCESS: 4,
-  EVENTS_TOTAL: 5  // EVENTS_TOTAL is not an event; all new events need to be
+  LOCATION_REQUEST: 5,
+  LOCATION_EVENT: 6,

[rgustafson, 2013/05/22 01:18:29]

Why location_event? location_update?

[vadimt, 2013/05/22 02:02:52]

Done.

+  EVENTS_TOTAL: 7  // EVENTS_TOTAL is not an event; all new events need to be
                    // added before it.
 };
 
@@ -363,6 +365,7 @@ function requestNotificationCards(position, callback) {
  */
 function requestLocation() {
   console.log('requestLocation');
+  recordEvent(DiagnosticEvent.LOCATION_REQUEST);
   // TODO(vadimt): Figure out location request options.
   chrome.location.watchLocation(LOCATION_WATCH_NAME, {});
 }
@@ -376,6 +379,7 @@ function requestLocation() {
 function updateNotificationsCards(position) {
   console.log('updateNotificationsCards ' + JSON.stringify(position) +
       ' @' + new Date());
+  recordEvent(DiagnosticEvent.LOCATION_EVENT);

[rgustafson, 2013/05/22 01:18:29]

It's not clear that this should only be called from onLocationUpdate. I don't
know if it's worth it to create another method that can easily be identified as
happening on location update then call this line and updateNotificationCards
from there, but just wanted to point that out. Don't need to change anything if
you don't think it will cause confusion later.

[vadimt, 2013/05/22 02:02:52]

Laziness :)

   tasks.add(UPDATE_CARDS_TASK_NAME, function(callback) {
     console.log('updateNotificationsCards-task-begin');
     updateCardsAttempts.planForNext(function() {