Adding location events to the histogram

chrome/browser/resources/google_now/background.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // 'use strict'; TODO(vadimt): Uncomment once crbug.com/237617 is fixed.
 
 /**
  * @fileoverview The event page for Google Now for Chrome implementation.
  * The Google Now event page gets Google Now cards from the server and shows
  * them as Chrome notifications.
@@ skipping 123 matching lines @@
 /**
  * Diagnostic event identifier.
  * @enum {number}
  */
 var DiagnosticEvent = {
   REQUEST_FOR_CARDS_TOTAL: 0,
   REQUEST_FOR_CARDS_SUCCESS: 1,
   CARDS_PARSE_SUCCESS: 2,
   DISMISS_REQUEST_TOTAL: 3,
   DISMISS_REQUEST_SUCCESS: 4,
-  EVENTS_TOTAL: 5  // EVENTS_TOTAL is not an event; all new events need to be
+  LOCATION_REQUEST: 5,
+  LOCATION_UPDATE: 6,
+  EVENTS_TOTAL: 7  // EVENTS_TOTAL is not an event; all new events need to be
                    // added before it.
 };
 
 /**
  * Records a diagnostic event.
  * @param {DiagnosticEvent} event Event identifier.
  */
 function recordEvent(event) {
   var metricDescription = {
     metricName: 'GoogleNow.Event',
@@ skipping 201 matching lines @@
   request.setRequestHeader('Content-type', 'application/x-www-form-urlencoded');
   tasks.debugSetStepName('requestNotificationCards-send-request');
   request.send(requestParameters);
 }
 
 /**
  * Starts getting location for a cards update.
  */
 function requestLocation() {
   console.log('requestLocation');
+  recordEvent(DiagnosticEvent.LOCATION_REQUEST);
   // TODO(vadimt): Figure out location request options.
   chrome.location.watchLocation(LOCATION_WATCH_NAME, {});
 }
 
 
 /**
  * Obtains new location; requests and shows notification cards based on this
  * location.
  * @param {Location} position Location of this computer.
  */
@@ skipping 220 matching lines @@
       onNotificationClicked(notificationId, function(actionUrls) {
         if (!Array.isArray(actionUrls.buttonUrls))
           return undefined;
 
         return actionUrls.buttonUrls[buttonIndex];
       });
     });
 
 chrome.notifications.onClosed.addListener(onNotificationClosed);
 
-chrome.location.onLocationUpdate.addListener(updateNotificationsCards);
+chrome.location.onLocationUpdate.addListener(function(position) {
+  recordEvent(DiagnosticEvent.LOCATION_UPDATE);
+  updateNotificationsCards(position);
+});