Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 1530583004: [turbofan] Use correct lazy frame state for JSCreate. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use correct lazy frame state for JSCreate. If JSCreate (which corresponds to %NewObject) would ever trigger a lazy deopt, we would deopt after the constructor call, skipping all the initialization and what else in the constructor function, which is wrong. Instead we can use the eager bailout point right before the constructor function, because allocation is not observable and so we can safely repeat the %NewObject in case of lazy bailout. R=yangguo@chromium.org BUG=v8:4544 LOG=n Committed: https://crrev.com/476296b96b9c3ca7a6cb72e6999bde981fe52873 Cr-Commit-Position: refs/heads/master@{#32880}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/compiler/js-inlining.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
5 years ago (2015-12-16 07:21:57 UTC) #1
Benedikt Meurer
Hey Yang, Here's the fix for the potential bug in constructor call inlining I mentioned. ...
5 years ago (2015-12-16 07:22:33 UTC) #2
Yang
On 2015/12/16 07:22:33, Benedikt Meurer wrote: > Hey Yang, > > Here's the fix for ...
5 years ago (2015-12-16 07:23:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530583004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530583004/1
5 years ago (2015-12-16 07:23:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-16 07:52:27 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-16 07:52:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/476296b96b9c3ca7a6cb72e6999bde981fe52873
Cr-Commit-Position: refs/heads/master@{#32880}

Powered by Google App Engine
This is Rietveld 408576698