Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tool/sdk_expected_errors.txt

Issue 1530563003: Generate all runtime files from dart. (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: simplify diff in js_codegen.dart Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/src/codegen/js_codegen.dart ('K') | « tool/input_sdk/private/utils.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tool/sdk_expected_errors.txt
diff --git a/tool/sdk_expected_errors.txt b/tool/sdk_expected_errors.txt
index e7f2696faf75c2a4b7d5ab9962e529f6224efd6c..d65a5a6026f544d9f5ed04e24c3cc5f0ad0ecd97 100644
--- a/tool/sdk_expected_errors.txt
+++ b/tool/sdk_expected_errors.txt
@@ -6,8 +6,8 @@ warning: [DOWN_CAST_COMPOSITE] msg['args'] (dynamic) will need runtime check to
warning: [DOWN_CAST_COMPOSITE] JS('var', r'#.pop()', this) (dynamic) will need runtime check to cast to type E (dart:_interceptors/js_array.dart, line 80, col 12)
warning: [DOWN_CAST_COMPOSITE] JS('', '#[#]', this, i) (dynamic) will need runtime check to cast to type E (dart:_interceptors/js_array.dart, line 125, col 9)
warning: [DOWN_CAST_COMPOSITE] JS('var', '#[#]', this, index) (dynamic) will need runtime check to cast to type E (dart:_interceptors/js_array.dart, line 313, col 12)
-warning: [DOWN_CAST_COMPOSITE] charCodes (dynamic) will need runtime check to cast to type List<int> (dart:_js_helper, line 264, col 31)
-warning: [DOWN_CAST_COMPOSITE] JS('', '#.value', ret) (dynamic) will need runtime check to cast to type E (dart:_js_helper, line 779, col 16)
+warning: [DOWN_CAST_COMPOSITE] charCodes (dynamic) will need runtime check to cast to type List<int> (dart:_js_helper, line 265, col 31)
+warning: [DOWN_CAST_COMPOSITE] JS('', '#.value', ret) (dynamic) will need runtime check to cast to type E (dart:_js_helper, line 780, col 16)
warning: [DOWN_CAST_COMPOSITE] JS('JSExtendableArray', r'#.split(#)', this, pattern) (dynamic) will need runtime check to cast to type List<String> (dart:_interceptors/js_string.dart, line 86, col 14)
warning: [DOWN_CAST_COMPOSITE] JS('JSExtendableArray', r'#.split(#)', this, re) (dynamic) will need runtime check to cast to type List<String> (dart:_interceptors/js_string.dart, line 89, col 14)
warning: [DOWN_CAST_COMPOSITE] JS('JSExtendableArray|Null', r'#.exec(#)', _nativeRegExp, checkString(string)) (dynamic) will need runtime check to cast to type List<String> (dart:_js_helper/regexp_helper.dart, line 108, col 22)
@@ -240,10 +240,6 @@ warning: [DOWN_CAST_COMPOSITE] test ((dynamic) → bool) will need runtime check
warning: [DOWN_CAST_COMPOSITE] list (List<dynamic>) will need runtime check to cast to type Iterable<T> (dart:_internal/iterable.dart, line 997, col 40)
warning: [DOWN_CAST_COMPOSITE] list (List<dynamic>) will need runtime check to cast to type Iterable<T> (dart:_internal/iterable.dart, line 1033, col 35)
warning: [DOWN_CAST_COMPOSITE] l (List<dynamic>) will need runtime check to cast to type List<T> (dart:_internal/iterable.dart, line 1115, col 31)
-warning: [DOWN_CAST_COMPOSITE] _convertToJS ((dynamic) → dynamic) will need runtime check to cast to type (E) → dynamic (dart:js, line 326, col 44)
-warning: [DOWN_CAST_COMPOSITE] super[index] (dynamic) will need runtime check to cast to type E (dart:js, line 359, col 12)
-warning: [DOWN_CAST_COMPOSITE] callMethod('splice', [index, 1])[0] (dynamic) will need runtime check to cast to type E (dart:js, line 405, col 12)
-warning: [DOWN_CAST_COMPOSITE] callMethod('pop') (dynamic) will need runtime check to cast to type E (dart:js, line 410, col 12)
warning: [DOWN_CAST_COMPOSITE] (a + b) * a * b (num) will need runtime check to cast to type T (dart:math, line 85, col 16)
warning: [DOWN_CAST_COMPOSITE] a + b (num) will need runtime check to cast to type T (dart:math, line 120, col 16)
warning: [DOWN_CAST_COMPOSITE] x + other.x (num) will need runtime check to cast to type T (dart:math/point.dart, line 37, col 25)
@@ -273,6 +269,10 @@ warning: [DOWN_CAST_COMPOSITE] max(a.x, b.x) - left (num) will need runtime chec
warning: [DOWN_CAST_COMPOSITE] max(a.y, b.y) - top (num) will need runtime check to cast to type T (dart:math/rectangle.dart, line 231, col 16)
warning: [DOWN_CAST_COMPOSITE] _clampToZero(width) (num) will need runtime check to cast to type T (dart:math/rectangle.dart, line 247, col 28)
warning: [DOWN_CAST_COMPOSITE] _clampToZero(height) (num) will need runtime check to cast to type T (dart:math/rectangle.dart, line 263, col 30)
+warning: [DOWN_CAST_COMPOSITE] _convertToJS ((dynamic) → dynamic) will need runtime check to cast to type (E) → dynamic (dart:js, line 326, col 44)
+warning: [DOWN_CAST_COMPOSITE] super[index] (dynamic) will need runtime check to cast to type E (dart:js, line 359, col 12)
+warning: [DOWN_CAST_COMPOSITE] callMethod('splice', [index, 1])[0] (dynamic) will need runtime check to cast to type E (dart:js, line 405, col 12)
+warning: [DOWN_CAST_COMPOSITE] callMethod('pop') (dynamic) will need runtime check to cast to type E (dart:js, line 410, col 12)
warning: [DOWN_CAST_COMPOSITE] interfaceThunk() (dynamic) will need runtime check to cast to type List<Type> (dart:_js_mirrors, line 127, col 31)
severe: [AnalyzerMessage] The setter 'classes' is not defined for the class 'Node' (dart:html, line 5484, col 32)
severe: [AnalyzerMessage] The method '_registerCustomElement' is not defined for the class 'HtmlDocument' (dart:html, line 8391, col 5)
« lib/src/codegen/js_codegen.dart ('K') | « tool/input_sdk/private/utils.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698