Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 1530543002: Make no_handle_scope_depth_ an int32_t field as that is what the accessor returns and there is chec… (Closed)

Created:
5 years ago by siva
Modified:
5 years ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make no_handle_scope_depth_ an int32_t field as that is what the accessor returns and there is check to ensure it;s value is < INT_MAX. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/956d02f22da5ba78ef6ca14ff51848fcfd11b94d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/vm/thread.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
5 years ago (2015-12-15 00:44:52 UTC) #2
Cutch
lgtm
5 years ago (2015-12-15 00:45:55 UTC) #3
siva
5 years ago (2015-12-15 01:28:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
956d02f22da5ba78ef6ca14ff51848fcfd11b94d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698