Add filters for user service.

Add filters for user service.

This brings the user service up to parity with the rest.

R=dnj@chromium.org, estaab@chromium.org, martiniss@chromium.org, vadimsh@chromium.org
BUG=

Committed: https://github.com/luci/gae/commit/6014627a303145614fb882022e7a9656a82b8408

[iannucci, 2015-12-15 00:38:28]

On 2015/12/15 at 00:37:05, iannucci wrote:
> 

it's mostly copypasta :)

Probably should think about making generators for count and featureBreaker...

[iannucci, 2015-12-15 00:38:42]

On 2015/12/15 at 00:38:28, iannucci wrote:
> On 2015/12/15 at 00:37:05, iannucci wrote:
> > 
> 
> it's mostly copypasta :)
> 
> Probably should think about making generators for count and featureBreaker...

(or maybe even service definitions for that matter...)

[iannucci, 2015-12-15 18:54:45]

(ping)

[dnj, 2015-12-15 18:59:30]

lgtm w/ comment

https://chromiumcodereview.appspot.com/1530533002/diff/1/filter/count/user.go
File filter/count/user.go (right):

https://chromiumcodereview.appspot.com/1530533002/diff/1/filter/count/user.go...
filter/count/user.go:32: u.c.Counter.up()
Why not named "Current"?

[dnj, 2015-12-15 18:59:30]

lgtm w/ comment

https://chromiumcodereview.appspot.com/1530533002/diff/1/filter/count/user.go
File filter/count/user.go (right):

https://chromiumcodereview.appspot.com/1530533002/diff/1/filter/count/user.go...
filter/count/user.go:32: u.c.Counter.up()
Why not named "Current"?

[iannucci, 2015-12-15 19:12:21]

This is exactly why I filed https://github.com/luci/gae/issues/30 :(

https://codereview.chromium.org/1530533002/diff/1/filter/count/user.go
File filter/count/user.go (right):

https://codereview.chromium.org/1530533002/diff/1/filter/count/user.go#newcode32
filter/count/user.go:32: u.c.Counter.up()
On 2015/12/15 at 18:59:30, dnj wrote:
> Why not named "Current"?

Lol. Boog.

[iannucci, 2015-12-15 19:12:30]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2015-12-15 19:12:30]

The patchset sent to the CQ was uploaded after l-g-t-m from dnj@chromium.org
Link to the patchset: https://codereview.chromium.org/1530533002/#ps20001
(title: "bug")

[commit-bot: I haz the power, 2015-12-15 19:12:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530533002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530533002/20001

[commit-bot: I haz the power, 2015-12-15 19:15:19]

Description was changed from

==========
Add filters for user service.

This brings the user service up to parity with the rest.

R=dnj@chromium.org, estaab@chromium.org, martiniss@chromium.org,
vadimsh@chromium.org
BUG=
==========

to

==========
Add filters for user service.

This brings the user service up to parity with the rest.

R=dnj@chromium.org, estaab@chromium.org, martiniss@chromium.org,
vadimsh@chromium.org
BUG=

Committed:
https://github.com/luci/gae/commit/6014627a303145614fb882022e7a9656a82b8408
==========

[commit-bot: I haz the power, 2015-12-15 19:15:20]

Committed patchset #2 (id:20001) as
https://github.com/luci/gae/commit/6014627a303145614fb882022e7a9656a82b8408