2D canvas: pass unmodified primitive bounds to saveLayer().

2D canvas: pass unmodified primitive bounds to saveLayer().

There is no longer a need for callers to call computeFastBounds() on
the bounds passed to SkCanvas::saveLayer(). Any margin required by
image filters in the SkPaint will be handled internally by Skia.

Also, rather than modifying the CTM and mapping the bounds by hand,
use an SkLocalMatrixImageFilter to apply the inverse CTM to filter
parameters, and pass the original primitive bounds. (2D canvas
semantics require that shadow offsets and other filter parameters
are unaffected by the CTM).

R=junov@chromium.org
BUG=570002
Committed: https://crrev.com/aea5bd2c15641110e9f9d5361134823af0e51d4f
Cr-Commit-Position: refs/heads/master@{#365477}

[Stephen White, 2015-12-15 20:30:19]

junov@: PTAL. Thanks!

[Justin Novosad, 2015-12-15 20:35:30]

lgtm, assuming the trybots like it.

[Stephen White, 2015-12-15 20:55:59]

The CQ bit was checked by senorblanco@chromium.org

[commit-bot: I haz the power, 2015-12-15 20:57:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530503004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530503004/1

[Stephen White, 2015-12-15 21:36:11]

The CQ bit was checked by senorblanco@chromium.org

[Stephen White, 2015-12-15 21:36:11]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org
Link to the patchset: https://codereview.chromium.org/1530503004/#ps20001
(title: "mark some more tests NeedsRebaseline")

[commit-bot: I haz the power, 2015-12-15 21:37:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530503004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530503004/20001

[commit-bot: I haz the power, 2015-12-15 22:59:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-15 22:59:38]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Stephen White, 2015-12-15 23:00:10]

The CQ bit was checked by senorblanco@chromium.org

[commit-bot: I haz the power, 2015-12-15 23:04:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530503004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530503004/20001

[commit-bot: I haz the power, 2015-12-16 01:26:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-16 01:26:39]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Stephen White, 2015-12-16 03:16:23]

The CQ bit was checked by senorblanco@chromium.org

[commit-bot: I haz the power, 2015-12-16 03:18:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530503004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530503004/20001

[commit-bot: I haz the power, 2015-12-16 05:46:24]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-16 05:47:59]

Description was changed from

==========
2D canvas: pass unmodified primitive bounds to saveLayer().

There is no longer a need for callers to call computeFastBounds() on
the bounds passed to SkCanvas::saveLayer(). Any margin required by
image filters in the SkPaint will be handled internally by Skia.

Also, rather than modifying the CTM and mapping the bounds by hand,
use an SkLocalMatrixImageFilter to apply the inverse CTM to filter
parameters, and pass the original primitive bounds. (2D canvas
semantics require that shadow offsets and other filter parameters
are unaffected by the CTM).

R=junov@chromium.org
BUG=570002
==========

to

==========
2D canvas: pass unmodified primitive bounds to saveLayer().

There is no longer a need for callers to call computeFastBounds() on
the bounds passed to SkCanvas::saveLayer(). Any margin required by
image filters in the SkPaint will be handled internally by Skia.

Also, rather than modifying the CTM and mapping the bounds by hand,
use an SkLocalMatrixImageFilter to apply the inverse CTM to filter
parameters, and pass the original primitive bounds. (2D canvas
semantics require that shadow offsets and other filter parameters
are unaffected by the CTM).

R=junov@chromium.org
BUG=570002

Committed: https://crrev.com/aea5bd2c15641110e9f9d5361134823af0e51d4f
Cr-Commit-Position: refs/heads/master@{#365477}
==========

[commit-bot: I haz the power, 2015-12-16 05:48:01]

Patchset 2 (id:??) landed as
https://crrev.com/aea5bd2c15641110e9f9d5361134823af0e51d4f
Cr-Commit-Position: refs/heads/master@{#365477}

[Justin Novosad, 2016-01-08 19:14:05]

https://codereview.chromium.org/1530503004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
(right):

https://codereview.chromium.org/1530503004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp:834:
SkMatrix ctm = c->getTotalMatrix();
Could you apply the same magic here as well?  Never mind conficts with my other
CL. I would like to re-write a fix on top of this awesomeness.

[Justin Novosad, 2016-01-08 19:15:18]

On 2016/01/08 19:14:05, Justin Novosad wrote:
>
https://codereview.chromium.org/1530503004/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp
> (right):
> 
>
https://codereview.chromium.org/1530503004/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp:834:
> SkMatrix ctm = c->getTotalMatrix();
> Could you apply the same magic here as well?  Never mind conficts with my
other
> CL. I would like to re-write a fix on top of this awesomenes

Eh nevermind. I'll do it in my CL