Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15305014: Remove reference to profile in devtools remote debugging initialization. (Closed)

Created:
7 years, 7 months ago by Tim Song
Modified:
7 years, 7 months ago
CC:
chromium-reviews, chrome-speed-team+watch_google.com, vsevik, yurys, pfeldman, telemetry+watch_chromium.org, xiyuan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove reference to profile in devtools remote debugging initialization. Use GetLastUsedProfile instead, so we can get the user profile after logging in on CrOS. BUG=242354 TEST=run_tests on CrOS Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202240

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -25 lines) Patch
M chrome/browser/browser_process.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browser_process_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browser_process_impl.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 1 2 3 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/devtools/browser_list_tabcontents_provider.h View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/devtools/browser_list_tabcontents_provider.cc View 1 2 3 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/devtools/remote_debugging_server.h View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/browser/devtools/remote_debugging_server.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/test/base/testing_browser_process.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/testing_browser_process.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Tim Song
This CL changes BrowserListTabContentsProvider to use the last user profile rather than the CrOS login ...
7 years, 7 months ago (2013-05-21 20:04:54 UTC) #1
achuithb
Great, LGTM from me, but please wait for comments from Pavel or Vlad
7 years, 7 months ago (2013-05-21 20:08:26 UTC) #2
pfeldman
lgtm provided it works ok with telemetry. https://codereview.chromium.org/15305014/diff/2001/chrome/browser/chrome_browser_main.cc File chrome/browser/chrome_browser_main.cc (right): https://codereview.chromium.org/15305014/diff/2001/chrome/browser/chrome_browser_main.cc#newcode473 chrome/browser/chrome_browser_main.cc:473: void LaunchDevToolsHandlerIfNeeded(Profile* ...
7 years, 7 months ago (2013-05-23 01:12:14 UTC) #3
nduca
cool ty :)
7 years, 7 months ago (2013-05-23 01:25:24 UTC) #4
Tim Song
https://codereview.chromium.org/15305014/diff/2001/chrome/browser/chrome_browser_main.cc File chrome/browser/chrome_browser_main.cc (right): https://codereview.chromium.org/15305014/diff/2001/chrome/browser/chrome_browser_main.cc#newcode473 chrome/browser/chrome_browser_main.cc:473: void LaunchDevToolsHandlerIfNeeded(Profile* profile, On 2013/05/23 01:12:14, pfeldman wrote: > ...
7 years, 7 months ago (2013-05-23 17:05:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tengs@chromium.org/15305014/9001
7 years, 7 months ago (2013-05-23 17:10:01 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=4624
7 years, 7 months ago (2013-05-23 17:17:46 UTC) #7
Tim Song
Sorry forgot reviewers for the chrome/browser files
7 years, 7 months ago (2013-05-23 17:27:02 UTC) #8
Tim Song
+jochen Can you take a look at these changes?
7 years, 7 months ago (2013-05-23 17:30:40 UTC) #9
jochen (gone - plz use gerrit)
lgtm
7 years, 7 months ago (2013-05-24 07:08:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tengs@chromium.org/15305014/9001
7 years, 7 months ago (2013-05-24 08:13:42 UTC) #11
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 7 months ago (2013-05-24 08:23:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tengs@chromium.org/15305014/39001
7 years, 7 months ago (2013-05-24 18:00:05 UTC) #13
commit-bot: I haz the power
7 years, 7 months ago (2013-05-25 00:13:16 UTC) #14
Message was sent while issue was closed. 
Change committed as 202240

Powered by Google App Engine
This is Rietveld 408576698