Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1495)

Unified Diff: chrome/browser/usb/web_usb_permission_bubble.cc

Issue 1530493002: Remove Close button for chooser bubble and call CloseBubble when Cancel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use BUBBLE_CLOSE_CANCELED for bubble close reason in Cancel function Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/usb/web_usb_permission_bubble.cc
diff --git a/chrome/browser/usb/web_usb_permission_bubble.cc b/chrome/browser/usb/web_usb_permission_bubble.cc
index c7ca5417692c1b51659c01d91c19826a2c60c1ad..4afbf8ac05f9b4e615720a2af6f3c492fc688330 100644
--- a/chrome/browser/usb/web_usb_permission_bubble.cc
+++ b/chrome/browser/usb/web_usb_permission_bubble.cc
@@ -31,10 +31,13 @@ void ChromeWebUsbPermissionBubble::GetPermission(
content::WebContents* web_contents =
content::WebContents::FromRenderFrameHost(render_frame_host_);
Browser* browser = chrome::FindBrowserWithWebContents(web_contents);
- scoped_ptr<BubbleDelegate> bubble_delegate(new UsbChooserBubbleDelegate(
- browser, device_filters.Pass(), render_frame_host_, callback));
+ scoped_ptr<UsbChooserBubbleDelegate> bubble_delegate(
+ new UsbChooserBubbleDelegate(browser, device_filters.Pass(),
Ken Rockot(use gerrit already) 2015/12/15 06:24:05 nit: since you're changing this code, please migra
juncai 2015/12/15 17:23:39 Done.
+ render_frame_host_, callback));
+ UsbChooserBubbleDelegate* bubble_delegate_ptr = bubble_delegate.get();
BubbleReference bubble_reference =
browser->GetBubbleManager()->ShowBubble(bubble_delegate.Pass());
+ bubble_delegate_ptr->set_bubble_reference(bubble_reference);
bubbles_.push_back(bubble_reference);
}

Powered by Google App Engine
This is Rietveld 408576698