Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Side by Side Diff: chrome/browser/usb/usb_chooser_bubble_delegate.h

Issue 1530493002: Remove Close button for chooser bubble and call CloseBubble when Cancel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: call CloseBubble when Select button is pressed Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_USB_USB_CHOOSER_BUBBLE_DELEGATE_H_ 5 #ifndef CHROME_BROWSER_USB_USB_CHOOSER_BUBBLE_DELEGATE_H_
6 #define CHROME_BROWSER_USB_USB_CHOOSER_BUBBLE_DELEGATE_H_ 6 #define CHROME_BROWSER_USB_USB_CHOOSER_BUBBLE_DELEGATE_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/memory/weak_ptr.h" 10 #include "base/memory/weak_ptr.h"
11 #include "base/scoped_observer.h" 11 #include "base/scoped_observer.h"
12 #include "chrome/browser/ui/website_settings/chooser_bubble_delegate.h" 12 #include "chrome/browser/ui/website_settings/chooser_bubble_delegate.h"
13 #include "components/bubble/bubble_reference.h"
13 #include "components/webusb/public/interfaces/webusb_permission_bubble.mojom.h" 14 #include "components/webusb/public/interfaces/webusb_permission_bubble.mojom.h"
14 #include "device/usb/usb_service.h" 15 #include "device/usb/usb_service.h"
15 #include "mojo/public/cpp/bindings/array.h" 16 #include "mojo/public/cpp/bindings/array.h"
16 17
17 namespace content { 18 namespace content {
18 class RenderFrameHost; 19 class RenderFrameHost;
19 } 20 }
20 21
21 namespace device { 22 namespace device {
22 class UsbDevice; 23 class UsbDevice;
(...skipping 19 matching lines...) Expand all
42 void Cancel() override; 43 void Cancel() override;
43 void Close() override; 44 void Close() override;
44 45
45 // device::UsbService::Observer: 46 // device::UsbService::Observer:
46 void OnDeviceAdded(scoped_refptr<device::UsbDevice> device) override; 47 void OnDeviceAdded(scoped_refptr<device::UsbDevice> device) override;
47 void OnDeviceRemoved(scoped_refptr<device::UsbDevice> device) override; 48 void OnDeviceRemoved(scoped_refptr<device::UsbDevice> device) override;
48 49
49 void GotUsbDeviceList( 50 void GotUsbDeviceList(
50 const std::vector<scoped_refptr<device::UsbDevice>>& devices); 51 const std::vector<scoped_refptr<device::UsbDevice>>& devices);
51 52
53 void set_bubble_reference(BubbleReference bubble_reference);
54
52 private: 55 private:
53 content::RenderFrameHost* const render_frame_host_; 56 content::RenderFrameHost* const render_frame_host_;
54 webusb::WebUsbPermissionBubble::GetPermissionCallback callback_; 57 webusb::WebUsbPermissionBubble::GetPermissionCallback callback_;
55 ScopedObserver<device::UsbService, device::UsbService::Observer> 58 ScopedObserver<device::UsbService, device::UsbService::Observer>
56 usb_service_observer_; 59 usb_service_observer_;
57 std::vector<device::UsbDeviceFilter> filters_; 60 std::vector<device::UsbDeviceFilter> filters_;
58 std::vector<scoped_refptr<device::UsbDevice>> devices_; 61 std::vector<scoped_refptr<device::UsbDevice>> devices_;
59 std::vector<base::string16> devices_names_; 62 std::vector<base::string16> devices_names_;
63 BubbleReference bubble_reference_;
felt 2015/12/17 02:16:59 nit: this is not a very descriptive name... could
juncai 2015/12/17 17:57:20 Done.
60 base::WeakPtrFactory<UsbChooserBubbleDelegate> weak_factory_; 64 base::WeakPtrFactory<UsbChooserBubbleDelegate> weak_factory_;
61 65
62 DISALLOW_COPY_AND_ASSIGN(UsbChooserBubbleDelegate); 66 DISALLOW_COPY_AND_ASSIGN(UsbChooserBubbleDelegate);
63 }; 67 };
64 68
65 #endif // CHROME_BROWSER_USB_USB_CHOOSER_BUBBLE_DELEGATE_H_ 69 #endif // CHROME_BROWSER_USB_USB_CHOOSER_BUBBLE_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698