Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: chrome/browser/usb/web_usb_permission_bubble.cc

Issue 1530493002: Remove Close button for chooser bubble and call CloseBubble when Cancel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use std::move instead of .Pass() Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/usb/usb_chooser_bubble_delegate.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/usb/web_usb_permission_bubble.h" 5 #include "chrome/browser/usb/web_usb_permission_bubble.h"
6 6
7 #include <utility>
8
7 #include "chrome/browser/ui/browser_finder.h" 9 #include "chrome/browser/ui/browser_finder.h"
8 #include "chrome/browser/ui/chrome_bubble_manager.h" 10 #include "chrome/browser/ui/chrome_bubble_manager.h"
9 #include "chrome/browser/usb/usb_chooser_bubble_delegate.h" 11 #include "chrome/browser/usb/usb_chooser_bubble_delegate.h"
10 #include "components/bubble/bubble_controller.h" 12 #include "components/bubble/bubble_controller.h"
11 #include "content/public/browser/browser_thread.h" 13 #include "content/public/browser/browser_thread.h"
12 #include "content/public/browser/render_frame_host.h" 14 #include "content/public/browser/render_frame_host.h"
13 15
14 ChromeWebUsbPermissionBubble::ChromeWebUsbPermissionBubble( 16 ChromeWebUsbPermissionBubble::ChromeWebUsbPermissionBubble(
15 content::RenderFrameHost* render_frame_host) 17 content::RenderFrameHost* render_frame_host)
16 : render_frame_host_(render_frame_host) { 18 : render_frame_host_(render_frame_host) {
17 DCHECK_CURRENTLY_ON(content::BrowserThread::UI); 19 DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
18 DCHECK(render_frame_host); 20 DCHECK(render_frame_host);
19 } 21 }
20 22
21 ChromeWebUsbPermissionBubble::~ChromeWebUsbPermissionBubble() { 23 ChromeWebUsbPermissionBubble::~ChromeWebUsbPermissionBubble() {
22 for (const auto& bubble : bubbles_) { 24 for (const auto& bubble : bubbles_) {
23 if (bubble) 25 if (bubble)
24 bubble->CloseBubble(BUBBLE_CLOSE_FORCED); 26 bubble->CloseBubble(BUBBLE_CLOSE_FORCED);
25 } 27 }
26 } 28 }
27 29
28 void ChromeWebUsbPermissionBubble::GetPermission( 30 void ChromeWebUsbPermissionBubble::GetPermission(
29 mojo::Array<device::usb::DeviceFilterPtr> device_filters, 31 mojo::Array<device::usb::DeviceFilterPtr> device_filters,
30 const GetPermissionCallback& callback) { 32 const GetPermissionCallback& callback) {
31 content::WebContents* web_contents = 33 content::WebContents* web_contents =
32 content::WebContents::FromRenderFrameHost(render_frame_host_); 34 content::WebContents::FromRenderFrameHost(render_frame_host_);
33 Browser* browser = chrome::FindBrowserWithWebContents(web_contents); 35 Browser* browser = chrome::FindBrowserWithWebContents(web_contents);
34 scoped_ptr<BubbleDelegate> bubble_delegate(new UsbChooserBubbleDelegate( 36 scoped_ptr<UsbChooserBubbleDelegate> bubble_delegate(
35 browser, device_filters.Pass(), render_frame_host_, callback)); 37 new UsbChooserBubbleDelegate(browser, std::move(device_filters),
36 BubbleReference bubble_reference = 38 render_frame_host_, callback));
37 browser->GetBubbleManager()->ShowBubble(bubble_delegate.Pass()); 39 UsbChooserBubbleDelegate* bubble_delegate_ptr = bubble_delegate.get();
38 bubbles_.push_back(bubble_reference); 40 BubbleReference bubble_controller =
41 browser->GetBubbleManager()->ShowBubble(std::move(bubble_delegate));
42 bubble_delegate_ptr->set_bubble_controller(bubble_controller);
43 bubbles_.push_back(bubble_controller);
39 } 44 }
40 45
41 void ChromeWebUsbPermissionBubble::Bind( 46 void ChromeWebUsbPermissionBubble::Bind(
42 mojo::InterfaceRequest<webusb::WebUsbPermissionBubble> request) { 47 mojo::InterfaceRequest<webusb::WebUsbPermissionBubble> request) {
43 DCHECK_CURRENTLY_ON(content::BrowserThread::UI); 48 DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
44 bindings_.AddBinding(this, request.Pass()); 49 bindings_.AddBinding(this, request.Pass());
45 } 50 }
OLDNEW
« no previous file with comments | « chrome/browser/usb/usb_chooser_bubble_delegate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698