Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java

Issue 1530473002: Fix three crashes in the recent tabs dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2564
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/DocumentRecentTabsManager.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java
index a1dfe0163e05fabd07a0c4c15710a700cdd36997..650e6547cec89972c13b93693e963e6abb302c89 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/RecentTabsManager.java
@@ -67,6 +67,7 @@ public class RecentTabsManager implements AndroidSyncSettingsObserver, SignInSta
private SigninManager mSignInManager;
private UpdatedCallback mUpdatedCallback;
private ProfileDataCache mProfileDataCache;
+ private boolean mIsDestroyed;
/**
* Create an RecentTabsManager to be used with RecentTabsPage and RecentTabsRowAdapter.
@@ -98,6 +99,7 @@ public class RecentTabsManager implements AndroidSyncSettingsObserver, SignInSta
* Should be called when this object is no longer needed. Performs necessary listener tear down.
*/
public void destroy() {
+ mIsDestroyed = true;
AndroidSyncSettings.unregisterObserver(mContext, this);
mSignInManager.removeSignInStateObserver(this);
@@ -125,6 +127,13 @@ public class RecentTabsManager implements AndroidSyncSettingsObserver, SignInSta
InvalidationController.get(mContext).onRecentTabsPageClosed();
}
+ /**
+ * Returns true if destroy() has been called.
+ */
+ public boolean isDestroyed() {
+ return mIsDestroyed;
+ }
+
private static ForeignSessionHelper buildForeignSessionHelper(Profile profile) {
return new ForeignSessionHelper(profile);
}
@@ -420,6 +429,7 @@ public class RecentTabsManager implements AndroidSyncSettingsObserver, SignInSta
ThreadUtils.runOnUiThread(new Runnable() {
@Override
public void run() {
+ if (mIsDestroyed) return;
updateForeignSessions();
postUpdate();
for (AndroidSyncSettingsObserver observer : mObservers) {
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/DocumentRecentTabsManager.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698