Issue 1530453002: Driver failure mode fixes (and test cleanup).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1530453002: Driver failure mode fixes (and test cleanup). (Closed)

Created:
5 years ago by pquitslund

Modified:
5 years ago

Reviewers:
keertip

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Driver failure mode fixes (and test cleanup). * `printAndFail(msg)` doesn't exit in testing (so we need to return null). R=keertip@google.com Committed: https://github.com/dart-lang/sdk/commit/fd0f649327dab7831f8f11a536bbbc6c9c00ede3

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -6 lines)			Patch
M	pkg/analyzer_cli/lib/src/options.dart	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	pkg/analyzer_cli/test/driver_test.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/analyzer_cli/test/utils.dart	View	3 chunks	+15 lines, -6 lines	0 comments	Download

Total messages: 5 (2 generated)

pquitslund

5 years ago (2015-12-14 21:58:10 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fd0f649327dab7831f8f11a536bbbc6c9c00ede3 (presubmit successful).