Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: net/quic/quic_connection.cc

Issue 1530443004: Change QuicConnection::ValidateAckFrame's DLOG(ERROR) to LOG(WARNING) in order to understand why th… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@109828260
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection.cc
diff --git a/net/quic/quic_connection.cc b/net/quic/quic_connection.cc
index 14a1fdd1e7d0dda61f4f7650e8325424862a4973..b35d1bd691e7b62b5224dda231cd40cff7521a53 100644
--- a/net/quic/quic_connection.cc
+++ b/net/quic/quic_connection.cc
@@ -781,17 +781,17 @@ bool QuicConnection::OnPingFrame(const QuicPingFrame& frame) {
bool QuicConnection::ValidateAckFrame(const QuicAckFrame& incoming_ack) {
if (incoming_ack.largest_observed > packet_generator_.packet_number()) {
- DLOG(ERROR) << ENDPOINT << "Peer's observed unsent packet:"
- << incoming_ack.largest_observed << " vs "
- << packet_generator_.packet_number();
+ LOG(WARNING) << ENDPOINT << "Peer's observed unsent packet:"
+ << incoming_ack.largest_observed << " vs "
+ << packet_generator_.packet_number();
// We got an error for data we have not sent. Error out.
return false;
}
if (incoming_ack.largest_observed < sent_packet_manager_.largest_observed()) {
- DLOG(ERROR) << ENDPOINT << "Peer's largest_observed packet decreased:"
- << incoming_ack.largest_observed << " vs "
- << sent_packet_manager_.largest_observed();
+ LOG(WARNING) << ENDPOINT << "Peer's largest_observed packet decreased:"
+ << incoming_ack.largest_observed << " vs "
+ << sent_packet_manager_.largest_observed();
// A new ack has a diminished largest_observed value. Error out.
// If this was an old packet, we wouldn't even have checked.
return false;
@@ -799,36 +799,35 @@ bool QuicConnection::ValidateAckFrame(const QuicAckFrame& incoming_ack) {
if (!incoming_ack.missing_packets.Empty() &&
incoming_ack.missing_packets.Max() > incoming_ack.largest_observed) {
- DLOG(ERROR) << ENDPOINT << "Peer sent missing packet: "
- << incoming_ack.missing_packets.Max()
- << " which is greater than largest observed: "
- << incoming_ack.largest_observed;
+ LOG(WARNING) << ENDPOINT << "Peer sent missing packet: "
+ << incoming_ack.missing_packets.Max()
+ << " which is greater than largest observed: "
+ << incoming_ack.largest_observed;
return false;
}
if (!incoming_ack.missing_packets.Empty() &&
incoming_ack.missing_packets.Min() <
sent_packet_manager_.least_packet_awaited_by_peer()) {
- DLOG(ERROR) << ENDPOINT << "Peer sent missing packet: "
- << incoming_ack.missing_packets.Min()
- << " which is smaller than least_packet_awaited_by_peer_: "
- << sent_packet_manager_.least_packet_awaited_by_peer();
+ LOG(WARNING) << ENDPOINT << "Peer sent missing packet: "
+ << incoming_ack.missing_packets.Min()
+ << " which is smaller than least_packet_awaited_by_peer_: "
+ << sent_packet_manager_.least_packet_awaited_by_peer();
return false;
}
- if (!sent_entropy_manager_.IsValidEntropy(
- incoming_ack.largest_observed,
- incoming_ack.missing_packets,
- incoming_ack.entropy_hash)) {
- DLOG(ERROR) << ENDPOINT << "Peer sent invalid entropy.";
+ if (!sent_entropy_manager_.IsValidEntropy(incoming_ack.largest_observed,
+ incoming_ack.missing_packets,
+ incoming_ack.entropy_hash)) {
+ LOG(WARNING) << ENDPOINT << "Peer sent invalid entropy.";
return false;
}
if (incoming_ack.latest_revived_packet != 0 &&
!incoming_ack.missing_packets.Contains(
incoming_ack.latest_revived_packet)) {
- DLOG(ERROR) << ENDPOINT
- << "Peer specified revived packet which was not missing.";
+ LOG(WARNING) << ENDPOINT
+ << "Peer specified revived packet which was not missing.";
return false;
}
return true;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698