Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1530433002: Remove directories in mojo/public/third_party that just mirrored third_party. (Closed)

Created:
5 years ago by jam
Modified:
5 years ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove directories in mojo/public/third_party that just mirrored third_party. This isn't needed now that the SDK is in the chrome repo. Committed: https://crrev.com/6c123eebf04d2aa9de44e87f4b8e3ee30285113e Cr-Commit-Position: refs/heads/master@{#365158} Committed: https://crrev.com/1d1464bda259fafb7b06e350ec10e880163f26ff Cr-Commit-Position: refs/heads/master@{#365294}

Patch Set 1 #

Patch Set 2 : upload after revert #

Patch Set 3 : with fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -16526 lines) Patch
D mojo/public/third_party/README.txt View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
D mojo/public/third_party/jinja2/AUTHORS View 1 2 1 chunk +0 lines, -33 lines 0 comments Download
D mojo/public/third_party/jinja2/Jinja2-2.7.1.tar.gz.md5 View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D mojo/public/third_party/jinja2/Jinja2-2.7.1.tar.gz.sha512 View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D mojo/public/third_party/jinja2/LICENSE View 1 2 1 chunk +0 lines, -31 lines 0 comments Download
D mojo/public/third_party/jinja2/OWNERS View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
D mojo/public/third_party/jinja2/README.chromium View 1 2 1 chunk +0 lines, -25 lines 0 comments Download
D mojo/public/third_party/jinja2/__init__.py View 1 2 1 chunk +0 lines, -69 lines 0 comments Download
D mojo/public/third_party/jinja2/_compat.py View 1 2 1 chunk +0 lines, -150 lines 0 comments Download
D mojo/public/third_party/jinja2/_stringdefs.py View 1 2 1 chunk +0 lines, -132 lines 0 comments Download
D mojo/public/third_party/jinja2/bccache.py View 1 2 1 chunk +0 lines, -311 lines 0 comments Download
D mojo/public/third_party/jinja2/compiler.py View 1 2 1 chunk +0 lines, -1640 lines 0 comments Download
D mojo/public/third_party/jinja2/constants.py View 1 2 1 chunk +0 lines, -32 lines 0 comments Download
D mojo/public/third_party/jinja2/debug.py View 1 2 1 chunk +0 lines, -337 lines 0 comments Download
D mojo/public/third_party/jinja2/defaults.py View 1 2 1 chunk +0 lines, -43 lines 0 comments Download
D mojo/public/third_party/jinja2/environment.py View 1 2 1 chunk +0 lines, -1191 lines 0 comments Download
D mojo/public/third_party/jinja2/exceptions.py View 1 2 1 chunk +0 lines, -146 lines 0 comments Download
D mojo/public/third_party/jinja2/ext.py View 1 2 1 chunk +0 lines, -636 lines 0 comments Download
D mojo/public/third_party/jinja2/filters.py View 1 2 1 chunk +0 lines, -987 lines 0 comments Download
D mojo/public/third_party/jinja2/get_jinja2.sh View 1 2 1 chunk +0 lines, -123 lines 0 comments Download
D mojo/public/third_party/jinja2/lexer.py View 1 2 1 chunk +0 lines, -733 lines 0 comments Download
D mojo/public/third_party/jinja2/loaders.py View 1 2 1 chunk +0 lines, -471 lines 0 comments Download
D mojo/public/third_party/jinja2/meta.py View 1 2 1 chunk +0 lines, -103 lines 0 comments Download
D mojo/public/third_party/jinja2/nodes.py View 1 2 1 chunk +0 lines, -914 lines 0 comments Download
D mojo/public/third_party/jinja2/optimizer.py View 1 2 1 chunk +0 lines, -68 lines 0 comments Download
D mojo/public/third_party/jinja2/parser.py View 1 2 1 chunk +0 lines, -895 lines 0 comments Download
D mojo/public/third_party/jinja2/runtime.py View 1 2 1 chunk +0 lines, -581 lines 0 comments Download
D mojo/public/third_party/jinja2/sandbox.py View 1 2 1 chunk +0 lines, -368 lines 0 comments Download
D mojo/public/third_party/jinja2/tests.py View 1 2 1 chunk +0 lines, -149 lines 0 comments Download
D mojo/public/third_party/jinja2/utils.py View 1 2 1 chunk +0 lines, -520 lines 0 comments Download
D mojo/public/third_party/jinja2/visitor.py View 1 2 1 chunk +0 lines, -87 lines 0 comments Download
D mojo/public/third_party/markupsafe/AUTHORS View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D mojo/public/third_party/markupsafe/LICENSE View 1 2 1 chunk +0 lines, -33 lines 0 comments Download
D mojo/public/third_party/markupsafe/MarkupSafe-0.18.tar.gz.md5 View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D mojo/public/third_party/markupsafe/MarkupSafe-0.18.tar.gz.sha512 View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D mojo/public/third_party/markupsafe/OWNERS View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
D mojo/public/third_party/markupsafe/README.chromium View 1 2 1 chunk +0 lines, -24 lines 0 comments Download
D mojo/public/third_party/markupsafe/__init__.py View 1 2 1 chunk +0 lines, -234 lines 0 comments Download
D mojo/public/third_party/markupsafe/_compat.py View 1 2 1 chunk +0 lines, -24 lines 0 comments Download
D mojo/public/third_party/markupsafe/_constants.py View 1 2 1 chunk +0 lines, -267 lines 0 comments Download
D mojo/public/third_party/markupsafe/_native.py View 1 2 1 chunk +0 lines, -46 lines 0 comments Download
D mojo/public/third_party/markupsafe/_speedups.c View 1 2 1 chunk +0 lines, -239 lines 0 comments Download
D mojo/public/third_party/markupsafe/get_markupsafe.sh View 1 2 1 chunk +0 lines, -121 lines 0 comments Download
D mojo/public/third_party/ply/LICENSE View 1 2 1 chunk +0 lines, -30 lines 0 comments Download
D mojo/public/third_party/ply/README View 1 2 1 chunk +0 lines, -271 lines 0 comments Download
D mojo/public/third_party/ply/README.chromium View 1 2 1 chunk +0 lines, -21 lines 0 comments Download
D mojo/public/third_party/ply/__init__.py View 1 2 1 chunk +0 lines, -36 lines 0 comments Download
D mojo/public/third_party/ply/lex.py View 1 2 1 chunk +0 lines, -1058 lines 0 comments Download
D mojo/public/third_party/ply/license.patch View 1 2 1 chunk +0 lines, -41 lines 0 comments Download
D mojo/public/third_party/ply/yacc.py View 1 2 1 chunk +0 lines, -3276 lines 0 comments Download
M mojo/public/tools/bindings/mojom_bindings_generator.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/generate/template_expander.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/parse/lexer.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/parse/parser.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/pylib/mojom_tests/parse/lexer_unittest.py View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (9 generated)
jam
5 years ago (2015-12-14 20:56:20 UTC) #3
jam
I filed https://code.google.com/p/chromium/issues/detail?id=569710 for the android try run failure.
5 years ago (2015-12-14 23:13:17 UTC) #4
Ken Rockot(use gerrit already)
lgtm
5 years ago (2015-12-15 04:54:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530433002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530433002/1
5 years ago (2015-12-15 05:11:11 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-15 05:23:29 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6c123eebf04d2aa9de44e87f4b8e3ee30285113e Cr-Commit-Position: refs/heads/master@{#365158}
5 years ago (2015-12-15 05:24:33 UTC) #11
hiroshige
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1526883002/ by hiroshige@chromium.org. ...
5 years ago (2015-12-15 05:51:01 UTC) #12
jam
ptal for patchset 2-3 (the M files)
5 years ago (2015-12-15 17:27:11 UTC) #14
Ken Rockot(use gerrit already)
lgtm :) I wondered if there was code that needed to be updated, but it ...
5 years ago (2015-12-15 17:31:04 UTC) #15
jam
On 2015/12/15 17:31:04, Ken Rockot wrote: > lgtm :) > > I wondered if there ...
5 years ago (2015-12-15 18:23:49 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530433002/20001
5 years ago (2015-12-15 18:25:06 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:20001)
5 years ago (2015-12-15 18:40:13 UTC) #20
commit-bot: I haz the power
5 years ago (2015-12-15 18:41:20 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1d1464bda259fafb7b06e350ec10e880163f26ff
Cr-Commit-Position: refs/heads/master@{#365294}

Powered by Google App Engine
This is Rietveld 408576698