Add template parameter for suffix to BinopXmm

Add template parameter for suffix to BinopXmm

BUG=
R=jpp@chromium.org, stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=6da7ae2b4e741b5bfdfbe747546ddb7cf0b2b4b5

[sehr, 2015-12-17 04:42:17]

Description was changed from

==========
Add template parameter for suffix to BinopXmm

BUG=
==========

to

==========
Add template parameter for suffix to BinopXmm

BUG=
==========

[sehr, 2015-12-17 04:42:17]

sehr@chromium.org changed reviewers:
+ jpp@chromium.org, kschimpf@chromium.org, stichnot@chromium.org

[sehr, 2015-12-17 04:42:32]

PTAL.

[Jim Stichnoth, 2015-12-17 07:26:44]

lgtm

[John, 2015-12-17 14:06:36]

lgtm

https://codereview.chromium.org/1530423002/diff/1/src/IceInstX86Base.h
File src/IceInstX86Base.h (right):

https://codereview.chromium.org/1530423002/diff/1/src/IceInstX86Base.h#newcod...
src/IceInstX86Base.h:773: char buf[30];
I know these routines don't make to the final binary, so this is totally
optional:

maybe refactor emitTwoAddress() to take the suffix as a second string argument.

while at it, refactor emitTwoAddress() so that it is no longer static (a static
method taking "this" as a parameters at every single call site is not really
static :))

If you want, I can send a patch with these changes.

[sehr, 2015-12-17 21:03:31]

I eliminated a few more emit method overrides also.  More refactoring can be
done in another CL.  PTAL.

https://codereview.chromium.org/1530423002/diff/1/src/IceInstX86Base.h
File src/IceInstX86Base.h (right):

https://codereview.chromium.org/1530423002/diff/1/src/IceInstX86Base.h#newcod...
src/IceInstX86Base.h:773: char buf[30];
On 2015/12/17 14:06:36, John wrote:
> I know these routines don't make to the final binary, so this is totally
> optional:
> 
> maybe refactor emitTwoAddress() to take the suffix as a second string
argument.
> 
> while at it, refactor emitTwoAddress() so that it is no longer static (a
static
> method taking "this" as a parameters at every single call site is not really
> static :))
> 
> If you want, I can send a patch with these changes.

Done.  And added another case for the Integral SSE instructions.

[John, 2015-12-17 21:07:51]

lgtm

https://codereview.chromium.org/1530423002/diff/20001/src/IceInstX86Base.h
File src/IceInstX86Base.h (right):

https://codereview.chromium.org/1530423002/diff/20001/src/IceInstX86Base.h#ne...
src/IceInstX86Base.h:162: const char *Suffix = nullptr) const;
optional: Suffix = "", then you can just

Str << Opcode << Suffix;

in the implementation.

[sehr, 2015-12-17 23:01:33]

Description was changed from

==========
Add template parameter for suffix to BinopXmm

BUG=
==========

to

==========
Add template parameter for suffix to BinopXmm

BUG=
R=jpp@chromium.org, stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[sehr, 2015-12-17 23:01:34]

Committed patchset #2 (id:20001) manually as
6da7ae2b4e741b5bfdfbe747546ddb7cf0b2b4b5 (presubmit successful).

[sehr, 2015-12-17 23:06:05]

Thanks.  Committed.

https://codereview.chromium.org/1530423002/diff/20001/src/IceInstX86Base.h
File src/IceInstX86Base.h (right):

https://codereview.chromium.org/1530423002/diff/20001/src/IceInstX86Base.h#ne...
src/IceInstX86Base.h:162: const char *Suffix = nullptr) const;
On 2015/12/17 21:07:51, John wrote:
> optional: Suffix = "", then you can just
> 
> Str << Opcode << Suffix;
> 
> in the implementation.

Done.