[Extensions] Fix install prompt icon bug

[Extensions] Fix install prompt icon bug

The install prompt was incorrectly fetching the icon for extensions. Fix it, and
add a unit test so it doesn't happen again.

BUG=570617
Committed: https://crrev.com/fc1499f89dd4beffc54e353956cfeb0c8f54ce9d
Cr-Commit-Position: refs/heads/master@{#366420}

[Devlin, 2015-12-17 22:21:14]

rdevlin.cronin@chromium.org changed reviewers:
+ asargent@chromium.org

[Devlin, 2015-12-17 22:21:15]

https://codereview.chromium.org/1530403005/diff/1/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_install_prompt.cc (right):

https://codereview.chromium.org/1530403005/diff/1/chrome/browser/extensions/e...
chrome/browser/extensions/extension_install_prompt.cc:673: SetIcon(icon);
D'oh.  Forgot that SetIcon() sets the default if |icon| is null, meaning that
LoadImageIfNeeded was always not needed.

https://codereview.chromium.org/1530403005/diff/1/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_install_prompt_unittest.cc (right):

https://codereview.chromium.org/1530403005/diff/1/chrome/browser/extensions/e...
chrome/browser/extensions/extension_install_prompt_unittest.cc:196:
std::vector<ImageLoader::ImageRepresentation> image_rep(
What a pain to look up an image!  Maybe that's next quarter's fix it ;)

[asargent_no_longer_on_chrome, 2015-12-17 22:40:40]

lgtm

https://codereview.chromium.org/1530403005/diff/1/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_install_prompt_unittest.cc (right):

https://codereview.chromium.org/1530403005/diff/1/chrome/browser/extensions/e...
chrome/browser/extensions/extension_install_prompt_unittest.cc:196:
std::vector<ImageLoader::ImageRepresentation> image_rep(
On 2015/12/17 22:21:14, Devlin wrote:
> What a pain to look up an image!  Maybe that's next quarter's fix it ;)

Hmm, I guess it could be marginally better if you could pass a single
ImageLoader::ImageRepresentation instead of having to pass a std:vector of them?


Also I would imagine there are a lot of cases where we want the combination of
the parameters EXTENSION_ICON_LARGE, MATCH_BIGGER, and SCALE_FACTOR_100P - maybe
we could have a static ImageRepresentation somewhere for that.

[Devlin, 2015-12-21 17:07:34]

https://codereview.chromium.org/1530403005/diff/1/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_install_prompt_unittest.cc (right):

https://codereview.chromium.org/1530403005/diff/1/chrome/browser/extensions/e...
chrome/browser/extensions/extension_install_prompt_unittest.cc:196:
std::vector<ImageLoader::ImageRepresentation> image_rep(
On 2015/12/17 22:40:40, asargent (away until Dec 29) wrote:
> On 2015/12/17 22:21:14, Devlin wrote:
> > What a pain to look up an image!  Maybe that's next quarter's fix it ;)
> 
> Hmm, I guess it could be marginally better if you could pass a single
> ImageLoader::ImageRepresentation instead of having to pass a std:vector of
them?
> 
> 
> Also I would imagine there are a lot of cases where we want the combination of
> the parameters EXTENSION_ICON_LARGE, MATCH_BIGGER, and SCALE_FACTOR_100P -
maybe
> we could have a static ImageRepresentation somewhere for that. 

Or it may be nice to have image loader do more of the work, so you can call it
with arguments like those to IconsInfo::GetIconResource.  Anyway.  Food for
thought.  Not this CL. :)

[Devlin, 2015-12-21 17:07:39]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2015-12-21 17:07:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/1530403005/#ps20001
(title: "Missing files")

[commit-bot: I haz the power, 2015-12-21 17:08:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530403005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530403005/20001

[commit-bot: I haz the power, 2015-12-21 18:22:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-12-21 18:22:55]

Description was changed from

==========
[Extensions] Fix install prompt icon bug

The install prompt was incorrectly fetching the icon for extensions. Fix it, and
add a unit test so it doesn't happen again.

BUG=570617
==========

to

==========
[Extensions] Fix install prompt icon bug

The install prompt was incorrectly fetching the icon for extensions. Fix it, and
add a unit test so it doesn't happen again.

BUG=570617

Committed: https://crrev.com/fc1499f89dd4beffc54e353956cfeb0c8f54ce9d
Cr-Commit-Position: refs/heads/master@{#366420}
==========

[commit-bot: I haz the power, 2015-12-21 18:22:56]

Patchset 2 (id:??) landed as
https://crrev.com/fc1499f89dd4beffc54e353956cfeb0c8f54ce9d
Cr-Commit-Position: refs/heads/master@{#366420}