Index: components/feedback/feedback_common_unittest.cc |
diff --git a/components/feedback/feedback_common_unittest.cc b/components/feedback/feedback_common_unittest.cc |
index d3fb9502210c7de0d591c84275b96038a58a6793..61895abb6bd1937676be985e9687902da14fa609 100644 |
--- a/components/feedback/feedback_common_unittest.cc |
+++ b/components/feedback/feedback_common_unittest.cc |
@@ -25,55 +25,56 @@ const char kLogsAttachmentName[] = "system_logs.zip"; |
class FeedbackCommonTest : public testing::Test { |
protected: |
FeedbackCommonTest() { |
- feedback = scoped_refptr<FeedbackCommon>(new FeedbackCommon()); |
+ feedback_ = scoped_refptr<FeedbackCommon>(new FeedbackCommon()); |
} |
~FeedbackCommonTest() override {} |
- scoped_refptr<FeedbackCommon> feedback; |
- userfeedback::ExtensionSubmit report; |
+ scoped_refptr<FeedbackCommon> feedback_; |
+ userfeedback::ExtensionSubmit report_; |
}; |
TEST_F(FeedbackCommonTest, TestBasicData) { |
// Test that basic data can be set and propagates to the request. |
- feedback->set_category_tag(kOne); |
- feedback->set_description(kTwo); |
- feedback->set_page_url(kThree); |
- feedback->set_user_email(kFour); |
- feedback->PrepareReport(&report); |
+ feedback_->set_category_tag(kOne); |
+ feedback_->set_description(kTwo); |
+ feedback_->set_page_url(kThree); |
+ feedback_->set_user_email(kFour); |
+ feedback_->PrepareReport(&report_); |
- EXPECT_EQ(kOne, report.bucket()); |
- EXPECT_EQ(kTwo, report.common_data().description()); |
- EXPECT_EQ(kThree, report.web_data().url()); |
- EXPECT_EQ(kFour, report.common_data().user_email()); |
+ EXPECT_EQ(kOne, report_.bucket()); |
+ EXPECT_EQ(kTwo, report_.common_data().description()); |
+ EXPECT_EQ(kThree, report_.web_data().url()); |
+ EXPECT_EQ(kFour, report_.common_data().user_email()); |
} |
TEST_F(FeedbackCommonTest, TestAddLogs) { |
- feedback->AddLog(kOne, kTwo); |
- feedback->AddLog(kThree, kFour); |
+ feedback_->AddLog(kOne, kTwo); |
+ feedback_->AddLog(kThree, kFour); |
- EXPECT_EQ(2U, feedback->sys_info()->size()); |
+ EXPECT_EQ(2U, feedback_->sys_info()->size()); |
} |
TEST_F(FeedbackCommonTest, TestCompressionThreshold) { |
// Add a large and small log, verify that only the small log gets |
// included in the report. |
- feedback->AddLog(kOne, kTwo); |
- feedback->AddLog(kThree, kLongLog); |
- feedback->PrepareReport(&report); |
+ feedback_->AddLog(kOne, kTwo); |
+ feedback_->AddLog(kThree, kLongLog); |
+ feedback_->PrepareReport(&report_); |
- EXPECT_EQ(1, report.web_data().product_specific_data_size()); |
- EXPECT_EQ(kOne, report.web_data().product_specific_data(0).key()); |
+ EXPECT_EQ(1, report_.web_data().product_specific_data_size()); |
+ EXPECT_EQ(kOne, report_.web_data().product_specific_data(0).key()); |
} |
TEST_F(FeedbackCommonTest, TestCompression) { |
// Add a large and small log, verify that an attachment has been |
// added with the right name. |
- feedback->AddLog(kOne, kTwo); |
- feedback->AddLog(kThree, kLongLog); |
- feedback->CompressLogs(); |
- feedback->PrepareReport(&report); |
+ feedback_->AddLog(kOne, kTwo); |
+ feedback_->AddLog(kThree, kLongLog); |
+ feedback_->CompressLogs(); |
+ feedback_->PrepareReport(&report_); |
- EXPECT_EQ(1, report.product_specific_binary_data_size()); |
- EXPECT_EQ(kLogsAttachmentName, report.product_specific_binary_data(0).name()); |
+ EXPECT_EQ(1, report_.product_specific_binary_data_size()); |
+ EXPECT_EQ(kLogsAttachmentName, |
+ report_.product_specific_binary_data(0).name()); |
} |