Chromium Code Reviews| Index: chrome/browser/feedback/system_logs/system_logs_fetcher_base.cc |
| diff --git a/chrome/browser/feedback/system_logs/system_logs_fetcher_base.cc b/chrome/browser/feedback/system_logs/system_logs_fetcher_base.cc |
| index 7a0b938005f75e5395aebde539ba34f42360c312..3ab7df954462f7b34e5f9b31d82dd09b94feeeac 100644 |
| --- a/chrome/browser/feedback/system_logs/system_logs_fetcher_base.cc |
| +++ b/chrome/browser/feedback/system_logs/system_logs_fetcher_base.cc |
| @@ -34,18 +34,29 @@ void SystemLogsFetcherBase::Fetch(const SysLogsFetcherCallback& callback) { |
| callback_ = callback; |
| for (size_t i = 0; i < data_sources_.size(); ++i) { |
| VLOG(1) << "Fetching SystemLogSource: " << data_sources_[i]->source_name(); |
| - data_sources_[i]->Fetch(base::Bind(&SystemLogsFetcherBase::AddResponse, |
| + data_sources_[i]->Fetch(base::Bind(&SystemLogsFetcherBase::OnFetched, |
| AsWeakPtr(), |
| data_sources_[i]->source_name())); |
| } |
| } |
| -void SystemLogsFetcherBase::AddResponse(const std::string& source_name, |
| - SystemLogsResponse* response) { |
| +void SystemLogsFetcherBase::OnFetched(const std::string& source_name, |
| + SystemLogsResponse* response) { |
| DCHECK_CURRENTLY_ON(BrowserThread::UI); |
| VLOG(1) << "Received SystemLogSource: " << source_name; |
| + Rewrite(source_name, response); |
| + AddResponse(source_name, response); |
| +} |
| + |
| +void SystemLogsFetcherBase::Rewrite(const std::string& source_name, |
|
rkc
2016/01/06 18:43:28
Nit: /* source_name */ and /* response */
battre
2016/01/07 09:54:02
Done.
|
| + SystemLogsResponse* response) { |
| + // This implementation in the base class is intentionally empty. |
| +} |
| + |
| +void SystemLogsFetcherBase::AddResponse(const std::string& source_name, |
| + SystemLogsResponse* response) { |
| for (SystemLogsResponse::const_iterator it = response->begin(); |
| it != response->end(); |
| ++it) { |