content/renderer/render_view_impl.cc - Issue 1530403002: Removal of geolocation APIs on insecure origins

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 1530403002: Removal of geolocation APIs on insecure origins (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Fix unit test Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index e0a78f13cc0cfa418f7a77d94a49778acbb02e1f..e15f2afdbf65948cbd21b90ea3f0cf1acf2ea1db 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -1003,6 +1003,8 @@ void RenderView::ApplyWebPreferences(const WebPreferences& prefs,

settings->setStrictPowerfulFeatureRestrictions(

prefs.strict_powerful_feature_restrictions);

+ settings->setAllowGeolocationOnInsecureOrigins(

+ prefs.allow_geolocation_on_insecure_origins);

settings->setPasswordEchoEnabled(prefs.password_echo_enabled);

settings->setShouldPrintBackgrounds(prefs.should_print_backgrounds);

settings->setShouldClearDocumentBackground(