Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: pkg/analysis_server/test/services/completion/optype_test.dart

Issue 1530393004: suggest IDENTIFIER not INVOCATION for dartdoc refs (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/completion/optype_test.dart
diff --git a/pkg/analysis_server/test/services/completion/optype_test.dart b/pkg/analysis_server/test/services/completion/optype_test.dart
index 3bcf191da1130cf19e97ea2f5f9cd426a7daa882..8fb29bf7f20cd6d8cc3f9412048e3aa56c75be67 100644
--- a/pkg/analysis_server/test/services/completion/optype_test.dart
+++ b/pkg/analysis_server/test/services/completion/optype_test.dart
@@ -15,6 +15,7 @@ import 'package:unittest/unittest.dart';
import '../../abstract_context.dart';
import '../../utils.dart';
+import 'package:analysis_server/src/protocol_server.dart';
main() {
initializeTestEnvironment();
@@ -52,7 +53,8 @@ class OpTypeTest {
bool statementLabel: false,
bool staticMethodBody: false,
bool typeNames: false,
- bool voidReturn: false}) {
+ bool voidReturn: false,
+ CompletionSuggestionKind kind: CompletionSuggestionKind.INVOCATION}) {
expect(visitor.includeCaseLabelSuggestions, caseLabel, reason: 'caseLabel');
expect(visitor.includeConstructorSuggestions, constructors,
reason: 'constructors');
@@ -66,6 +68,7 @@ class OpTypeTest {
expect(visitor.inStaticMethodBody, staticMethodBody,
reason: 'staticMethodBody');
expect(visitor.isPrefixed, prefixed, reason: 'prefixed');
+ expect(visitor.suggestKind, kind, reason: 'suggestion kind');
}
void processRequiredPlugins() {
@@ -405,7 +408,11 @@ class OpTypeTest {
test_CommentReference() {
// SimpleIdentifier CommentReference Comment MethodDeclaration
addTestSource('class A {/** [^] */ mth() {}');
- assertOpType(returnValue: true, typeNames: true, voidReturn: true);
+ assertOpType(
+ returnValue: true,
+ typeNames: true,
+ voidReturn: true,
+ kind: CompletionSuggestionKind.IDENTIFIER);
}
test_ConditionalExpression_elseExpression() {
« no previous file with comments | « pkg/analysis_server/test/services/completion/dart/local_reference_contributor_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698