WIP: Move 'X-Frame-Options' checking to the browser.

content/public/browser/navigation_throttle.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_THROTTLE_H_
 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_THROTTLE_H_
 
 #include "content/common/content_export.h"
 
 namespace content {
@@ skipping 14 matching lines @@
     // If the NavigationHandle is destroyed while the navigation is deferred,
     // the navigation will be canceled in the network stack.
     DEFER,
 
     // Cancels the navigation.
     CANCEL,
 
     // Cancels the navigation and makes the requester of the navigation acts
     // like the request was never made.
     CANCEL_AND_IGNORE,
+
+    // Block the navigation.
+    BLOCK,
   };
 
   NavigationThrottle(NavigationHandle* navigation_handle);
   virtual ~NavigationThrottle();
 
   // Called when a network request is about to be made for this navigation.
   //
   // The implementer is responsible for ensuring that the WebContents this
   // throttle is associated with remain alive during the duration of this
   // method. Failing to do so will result in use-after-free bugs. Should the
   // implementer need to destroy the WebContents, it should return CANCEL,
   // CANCEL_AND_IGNORE or DEFER and perform the destruction asynchronously.
   virtual ThrottleCheckResult WillStartRequest();
 
   // Called when a server redirect is received by the navigation.
   //
   // The implementer is responsible for ensuring that the WebContents this
   // throttle is associated with remain alive during the duration of this
   // method. Failing to do so will result in use-after-free bugs. Should the
   // implementer need to destroy the WebContents, it should return CANCEL,
   // CANCEL_AND_IGNORE or DEFER and perform the destruction asynchronously.
   virtual ThrottleCheckResult WillRedirectRequest();
 
+  // Called when a network response is ready to commit for this navigation.
+  //
+  // The implementer is responsible for ensuring that the WebContents this
+  // throttle is associated with remain alive during the duration of this
+  // method. Failing to do so will result in use-after-free bugs. Should the
+  // implementer need to destroy the WebContents, it should return CANCEL or
+  // CANCEL_AND_IGNORE and perform the destruction asynchronously. This method
+  // must not return DEFER, as it is the last step before committing.

[nasko, 2016/01/20 23:15:07]

Should we be adding BLOCK to the lists of possible results in these comments?

[Mike West, 2016/01/21 14:51:24]

We should, and have. Thanks!

+  virtual ThrottleCheckResult WillProcessResponse();
+
   // The NavigationHandle that is tracking the information related to this
   // navigation.
   NavigationHandle* navigation_handle() const { return navigation_handle_; }
 
  private:
   NavigationHandle* navigation_handle_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_NAVIGATION_THROTTLE_H_