WIP: Move 'X-Frame-Options' checking to the browser.

content/browser/frame_host/xfo_throttle.h

+// Copyright 2015 The Chromium Authors. All rights reserved.

[nasko, 2016/01/20 23:15:07]

2016 :)

[Mike West, 2016/01/21 14:51:24]

It was 2015 when I started. :)

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_SECURITY_XFO_THROTTLE_H_
+#define CHROME_BROWSER_SECURITY_XFO_THROTTLE_H_
+
+#include "base/memory/scoped_ptr.h"
+#include "content/public/browser/navigation_throttle.h"
+
+namespace content {
+class NavigationHandle;
+}
+
+namespace net {
+class HttpResponseHeaders;
+}
+
+namespace content {
+
+class CONTENT_EXPORT XFOThrottle : public NavigationThrottle {

[nasko, 2016/01/20 23:15:07]

XfoThrottle, as per semi-recent chromium-dev@ discussions on capitalization.

[Mike West, 2016/01/21 14:51:24]

...

Style rules never get better, do they? They just trend slowly and inexorably
towards terribleness. :(

+ public:
+  enum HeaderDisposition {
+    NOT_PRESENT,
+    DENY,
+    SAMEORIGIN,

[nasko, 2016/01/20 23:15:07]

Why use _ in NOT_PRESENT, but not in SAME_ORITIN and ALLOW_ALL?

[Mike West, 2016/01/21 14:51:24]

Changed to `NONE` to avoid the question.

+    ALLOWALL,
+    INVALID,
+    CONFLICT
+  };
+
+  explicit XFOThrottle(NavigationHandle* handle);
+  ~XFOThrottle() override;
+
+  NavigationThrottle::ThrottleCheckResult WillProcessResponse() override;
+  static scoped_ptr<NavigationThrottle> MaybeCreateThrottleFor(

[nasko, 2016/01/20 23:15:07]

Static methods go first in the class, especially creation related ones.

[Mike West, 2016/01/21 14:51:24]

Done.

+      NavigationHandle* handle);
+
+  // Parses an 'X-Frame-Options' header. If the result is either CONFLICT
+  // or INVALID, |failed_parse| will be populated with the value which caused
+  // the parse error.
+  static HeaderDisposition ParseHeader(const net::HttpResponseHeaders* headers,
+                                       std::string* failed_parse);
+
+ private:
+  void ParseError(const std::string& value, HeaderDisposition disposition);
+  void ConsoleError(HeaderDisposition disposition);
+
+  DISALLOW_COPY_AND_ASSIGN(XFOThrottle);
+};
+
+}  // namespace content
+
+#endif  // CHROME_BROWSER_SECURITY_XFO_THROTTLE_H_