third_party/WebKit/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny.html - Issue 1530393003: WIP: Move 'X-Frame-Options' checking to the browser.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny.html

Issue 1530393003: WIP: Move 'X-Frame-Options' checking to the browser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Moar. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/shell/renderer/shell_content_renderer_client.cc ('k') | third_party/WebKit/LayoutTests/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <script>	1 <script>

2 if (window.testRunner) {	2 if (window.testRunner) {

3 testRunner.dumpAsText();	3 testRunner.dumpAsText();

4 testRunner.dumpChildFramesAsText();	4 testRunner.dumpChildFramesAsText();

5 testRunner.dumpResourceLoadCallbacks();	5 testRunner.dumpResourceLoadCallbacks();

6 testRunner.waitUntilDone();	6 testRunner.waitUntilDone();

7 }	7 }

8	8

9 function checkIfDone() {	9 function checkIfDone() {

10 try {	10 try {

11 var url = document.querySelector('iframe').contentWindow.location.hr ef;	11 var url = document.querySelector('iframe').contentWindow.location.hr ef;

12 console.log("FAIL: Could read contentWindow.location.href");	12 console.log("FAIL: Could read contentWindow.location.href");

13 } catch (e) {	13 } catch (e) {

14 console.log("PASS: Access to contentWindow.location.href threw an ex ception.");	14 console.log("PASS: Access to contentWindow.location.href threw an ex ception.");

15 }	15 }

16	16

17 testRunner.notifyDone();	17 testRunner.notifyDone();

18 }	18 }

19 </script>	19 </script>

20	20

21 <p>There should be no content in the iframe below</p>	21 <p>There should be no content in the iframe below</p>

22 <iframe style="width:500px; height:500px" src="http://127.0.0.1:8000/security/XF rameOptions/resources/x-frame-options-deny.cgi" onload="checkIfDone()"></iframe>	22 <iframe style="width:500px; height:500px" src="http://127.0.0.1:8000/security/XF rameOptions/resources/x-frame-options-deny.cgi" onload="checkIfDone()" onerror=" checkIfDone()"></iframe>
	Mike West 2016/01/18 13:26:00 I don't understand why this isn't triggering; if I I don't understand why this isn't triggering; if I load it up in `content_shell`, the test passes. If I load it with `--run-layout-test`, the `load` event never fires (neither does the `error` event, but it shouldn't...). ~4 tests are failing because of this. Halp!
OLD	NEW