Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1148)

Issue 1530363002: Fix summary resynthesis for operators ending in '='. (Closed)

Created:
5 years ago by Paul Berry
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Konstantin's suggestion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2 lines) Patch
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 2 chunks +12 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_test.dart View 3 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
5 years ago (2015-12-16 21:45:56 UTC) #2
Paul Berry
PTAL
5 years ago (2015-12-16 21:50:40 UTC) #3
scheglov
LGTM
5 years ago (2015-12-16 21:57:48 UTC) #4
Paul Berry
5 years ago (2015-12-16 21:59:20 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7adf62209df9f94a4429adcc49161c975560aa5c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698