DevTools: jump from computed style to styles sidebar pane.

DevTools: jump from computed style to styles sidebar pane.

BUG=496263
R=pfeldman

Committed: https://crrev.com/28fffc7579add5c7ec81c25dabc80d9732ed7382
Cr-Commit-Position: refs/heads/master@{#370344}

[pfeldman, 2015-12-17 20:26:32]

You should not need a revealer since everything is taking place in the same
module.

[lushnikov, 2015-12-18 03:48:31]

On 2015/12/17 20:26:32, pfeldman wrote:
> You should not need a revealer since everything is taking place in the same
> module.

In an ideal world, CSSP would be in its own module.

[pfeldman, 2016-01-04 21:28:05]

On 2015/12/18 03:48:31, lushnikov wrote:
> On 2015/12/17 20:26:32, pfeldman wrote:
> > You should not need a revealer since everything is taking place in the same
> > module.
> 
> In an ideal world, CSSP would be in its own module.

I still don't like it since all the CSS entities are transient and are scoped to
the styles "module".

[lushnikov, 2016-01-14 22:33:53]

killed revealer. ptal.

[pfeldman, 2016-01-16 01:00:47]

lgtm

https://codereview.chromium.org/1530353003/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/elements/PropertyChangeHighlighter.js
(right):

https://codereview.chromium.org/1530353003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/elements/PropertyChangeHighlighter.js:110:
for (var treeElement = section.propertiesTreeOutline.firstChild(); treeElement;
treeElement = treeElement.nextSibling)
how much do we want this class to know about the styles sidebar pane? traversing
tree elements might be too much. Should it be moved into ssp?

[lushnikov, 2016-01-16 01:38:55]

https://codereview.chromium.org/1530353003/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/elements/PropertyChangeHighlighter.js
(right):

https://codereview.chromium.org/1530353003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/elements/PropertyChangeHighlighter.js:110:
for (var treeElement = section.propertiesTreeOutline.firstChild(); treeElement;
treeElement = treeElement.nextSibling)
The patch doesn't change the approach from this point of view; we can discuss
any way of dealing with this offline.

[lushnikov, 2016-01-16 01:39:00]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-01-16 01:39:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530353003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530353003/60001

[commit-bot: I haz the power, 2016-01-16 01:42:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-16 01:42:22]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lushnikov, 2016-01-20 02:11:49]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-01-20 02:11:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1530353003/#ps80001
(title: "rebaseline")

[commit-bot: I haz the power, 2016-01-20 02:13:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530353003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530353003/80001

[commit-bot: I haz the power, 2016-01-20 02:38:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 02:38:40]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lushnikov, 2016-01-20 08:01:50]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-01-20 08:03:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530353003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530353003/80001

[commit-bot: I haz the power, 2016-01-20 08:49:50]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-01-20 08:50:37]

Description was changed from

==========
DevTools: jump from computed style to styles sidebar pane.

BUG=496263
R=pfeldman
==========

to

==========
DevTools: jump from computed style to styles sidebar pane.

BUG=496263
R=pfeldman

Committed: https://crrev.com/28fffc7579add5c7ec81c25dabc80d9732ed7382
Cr-Commit-Position: refs/heads/master@{#370344}
==========

[commit-bot: I haz the power, 2016-01-20 08:50:38]

Patchset 5 (id:??) landed as
https://crrev.com/28fffc7579add5c7ec81c25dabc80d9732ed7382
Cr-Commit-Position: refs/heads/master@{#370344}