fix license file formatting

fix license file formatting

[Mostyn Bramley-Moore, 2015-12-17 14:45:17]

mostynb@opera.com changed reviewers:
+ jshin@chromium.org

[Mostyn Bramley-Moore, 2015-12-17 14:45:17]

@jungshik: here's a small patch to fix the formatting in the ICU LICENSE file-
is this file the output of some automatic processing, or hand-edited from the
ICU source?

[jungshik at Google, 2015-12-18 22:35:07]

Thank you for taking care of this. 

What do you think of my comment below about 'multiline (relatively short)' vs
'very long line'?  

As for this file, yes, I kinda manually converted license.html in the upstream
source to a plain text file (with lynx or something).

https://codereview.chromium.org/1530343003/diff/1/LICENSE
File LICENSE (right):

https://codereview.chromium.org/1530343003/diff/1/LICENSE#newcode103
LICENSE:103: #      THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR
CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY,
OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY
OF SUCH DAMAGE.
Wouldn't it be better to make this paragraph multilines instead of a very long
line?

There are other changes like this. The same can be said of them, too.

[Mostyn Bramley-Moore, 2015-12-18 22:47:47]

https://codereview.chromium.org/1530343003/diff/1/LICENSE
File LICENSE (right):

https://codereview.chromium.org/1530343003/diff/1/LICENSE#newcode103
LICENSE:103: #      THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR
CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY,
OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING
IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY
OF SUCH DAMAGE.
On 2015/12/18 22:35:07, jshin (out until Jan 3) wrote:
> Wouldn't it be better to make this paragraph multilines instead of a very long
> line?
> 
> There are other changes like this. The same can be said of them, too.  

That would be better, since this is wrapped in <pre> tags in chrome://credits. 
Though it sounds like more effort.  I will upload a patch and you can see what
you think.

[Mostyn Bramley-Moore, 2016-01-13 15:53:07]

*ping*

[jungshik at Google, 2016-01-15 21:00:18]

Thanks. LGTM

[Mostyn Bramley-Moore, 2016-02-08 20:18:46]

Landed over here: https://codereview.chromium.org/1678243002/

Closing this.