Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 1530313002: Fix thread-unsafe construction of GrUniqueKey in GR_DEFINE_STATIC_UNIQUE_KEY (Closed)

Created:
5 years ago by bsalomon
Modified:
5 years ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : compiles #

Patch Set 3 : more constness #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M include/gpu/GrResourceKey.h View 1 2 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
bsalomon
5 years ago (2015-12-16 21:14:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530313002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530313002/40001
5 years ago (2015-12-16 21:14:14 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years ago (2015-12-16 21:14:15 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years ago (2015-12-17 03:14:10 UTC) #8
robertphillips
lgtm
5 years ago (2015-12-17 13:31:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530313002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530313002/40001
5 years ago (2015-12-17 16:15:14 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-17 16:15:52 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/f0795ab1f2556b5ef45ee48983c32d5d0be0a8da

Powered by Google App Engine
This is Rietveld 408576698