Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 1530303005: Separate prelinked and unlinked parts of summaries. (Closed)

Created:
5 years ago by Paul Berry
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Separate prelinked and unlinked parts of summaries. This will allow summaries to be "re-linked" without having to touch their UnlinkedUnit data structures (which are much larger than the corresponding prelinked data). R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/3ff75cc7233556334267ebb7db75bec7abd49fc6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+264 lines, -179 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 5 chunks +6 lines, -14 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 14 chunks +56 lines, -33 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 5 chunks +50 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 2 chunks +28 lines, -14 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_test.dart View 25 chunks +123 lines, -107 lines 0 comments Download
M pkg/analyzer/tool/summary/idl.dart View 2 chunks +1 line, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
With this CL, I believe the interface to SummaryResynthesizer should now be fairly stable. So ...
5 years ago (2015-12-17 20:58:06 UTC) #2
scheglov
LGTM
5 years ago (2015-12-17 21:10:58 UTC) #3
Paul Berry
5 years ago (2015-12-17 22:27:15 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3ff75cc7233556334267ebb7db75bec7abd49fc6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698