[proxies] Better print for proxies in d8

[proxies] Better print for proxies in d8

Function proxies would not be printed so far since they ended up in Function.prototype.toString which only works with Function as a receiver but no Proxy. Additionally added support for more gracefully dealing with recursive __proto__ structures introduced by proxies.

drive-by-fix: use IS_PROXY if possible in .js files.

BUG=v8:1543
LOG=n

Committed: https://crrev.com/8bfb7189a3472bc9d0820a1bd4534eaaf78ff847
Cr-Commit-Position: refs/heads/master@{#32985}

Committed: https://crrev.com/b7ff2bd5cdfdd22cbfaa510e1c42e70f4ea1d8a3
Cr-Commit-Position: refs/heads/master@{#33010}

[Camillo Bruni, 2015-12-17 09:47:22]

cbruni@chromium.org changed reviewers:
+ neis@chromium.org

[Camillo Bruni, 2015-12-17 09:47:23]

PTAL

[Camillo Bruni, 2015-12-17 10:43:08]

https://codereview.chromium.org/1530293004/diff/20001/src/js/macros.py
File src/js/macros.py (right):

https://codereview.chromium.org/1530293004/diff/20001/src/js/macros.py#newcod...
src/js/macros.py:122: macro IS_WEAKSET(arg)           = (%_ClassOf(arg) ===
'WeakSet');
I sorted the macros and add IS_PROXY

[neis, 2015-12-17 11:45:19]

On 2015/12/17 at 10:43:08, cbruni wrote:
> https://codereview.chromium.org/1530293004/diff/20001/src/js/macros.py
> File src/js/macros.py (right):
> 
>
https://codereview.chromium.org/1530293004/diff/20001/src/js/macros.py#newcod...
> src/js/macros.py:122: macro IS_WEAKSET(arg)           = (%_ClassOf(arg) ===
'WeakSet');
> I sorted the macros and add IS_PROXY

Please rename any other uses of %IsJSProxy and %_IsJSProxy to IS_PROXY.

[Camillo Bruni, 2015-12-17 14:04:16]

PTAL

[neis, 2015-12-17 14:07:29]

On 2015/12/17 14:04:16, cbruni wrote:
> PTAL

Great, thanks!
lgtm

[Camillo Bruni, 2015-12-17 14:08:43]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2015-12-17 14:08:43]

The patchset sent to the CQ was uploaded after l-g-t-m from neis@chromium.org
Link to the patchset: https://codereview.chromium.org/1530293004/#ps80001
(title: "removing unused helper")

[commit-bot: I haz the power, 2015-12-17 14:08:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530293004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530293004/80001

[commit-bot: I haz the power, 2015-12-17 14:19:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-17 14:19:32]

Try jobs failed on following builders:
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/13391)

[Camillo Bruni, 2015-12-21 09:27:53]

Description was changed from

==========
[proxies] Better print for proxies in d8

BUG=v8:1543
==========

to

==========
[proxies] Better print for proxies in d8

Function proxies would not be printed so far since they ended up in
Function.prototype.toString which only works with Function as a receiver but no
Proxy. Additionally added support for more gracefully dealing with recursive
__proto__ structures introduced by proxies.


BUG=v8:1543
==========

[Camillo Bruni, 2015-12-21 09:27:57]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2015-12-21 09:27:58]

The patchset sent to the CQ was uploaded after l-g-t-m from neis@chromium.org
Link to the patchset: https://codereview.chromium.org/1530293004/#ps100001
(title: "merge with master")

[commit-bot: I haz the power, 2015-12-21 09:28:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530293004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530293004/100001

[commit-bot: I haz the power, 2015-12-21 09:30:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-21 09:30:59]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9165)

[Camillo Bruni, 2015-12-21 10:05:04]

cbruni@chromium.org changed reviewers:
+ yangguo@chromium.org

[Camillo Bruni, 2015-12-21 10:05:05]

yang: PTAL (need rubberstamp)

[Yang, 2015-12-21 10:13:19]

On 2015/12/21 10:05:05, cbruni wrote:
> yang: PTAL (need rubberstamp)

rubberstamp lgtm.

[Camillo Bruni, 2015-12-21 10:38:30]

The CQ bit was checked by cbruni@chromium.org

[commit-bot: I haz the power, 2015-12-21 10:38:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530293004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530293004/100001

[commit-bot: I haz the power, 2015-12-21 10:40:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-21 10:40:52]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9171)

[Camillo Bruni, 2015-12-21 12:45:52]

Description was changed from

==========
[proxies] Better print for proxies in d8

Function proxies would not be printed so far since they ended up in
Function.prototype.toString which only works with Function as a receiver but no
Proxy. Additionally added support for more gracefully dealing with recursive
__proto__ structures introduced by proxies.


BUG=v8:1543
==========

to

==========
[proxies] Better print for proxies in d8

Function proxies would not be printed so far since they ended up in
Function.prototype.toString which only works with Function as a receiver but no
Proxy. Additionally added support for more gracefully dealing with recursive
__proto__ structures introduced by proxies.


BUG=v8:1543
LOG=n
==========

[Camillo Bruni, 2015-12-21 12:45:53]

The CQ bit was checked by cbruni@chromium.org

[commit-bot: I haz the power, 2015-12-21 12:46:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530293004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530293004/100001

[commit-bot: I haz the power, 2015-12-21 12:47:21]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-12-21 12:47:49]

Description was changed from

==========
[proxies] Better print for proxies in d8

Function proxies would not be printed so far since they ended up in
Function.prototype.toString which only works with Function as a receiver but no
Proxy. Additionally added support for more gracefully dealing with recursive
__proto__ structures introduced by proxies.


BUG=v8:1543
LOG=n
==========

to

==========
[proxies] Better print for proxies in d8

Function proxies would not be printed so far since they ended up in
Function.prototype.toString which only works with Function as a receiver but no
Proxy. Additionally added support for more gracefully dealing with recursive
__proto__ structures introduced by proxies.

BUG=v8:1543
LOG=n

Committed: https://crrev.com/8bfb7189a3472bc9d0820a1bd4534eaaf78ff847
Cr-Commit-Position: refs/heads/master@{#32985}
==========

[commit-bot: I haz the power, 2015-12-21 12:47:50]

Patchset 6 (id:??) landed as
https://crrev.com/8bfb7189a3472bc9d0820a1bd4534eaaf78ff847
Cr-Commit-Position: refs/heads/master@{#32985}

[Dan Ehrenberg, 2015-12-22 01:26:10]

With this patch, I seem to need to pass --allow-natives-syntax to d8 to get it
to run interactively.

[caitp (gmail), 2015-12-22 04:13:58]

On 2015/12/22 01:26:10, Dan Ehrenberg wrote:
> With this patch, I seem to need to pass --allow-natives-syntax to d8 to get it
> to run interactively.

Something similar to NoUseStrongForUtilityScriptScope might be in order. It
seems like js2c should be able to encode flags that are needed for whatever
internal scripts though

[Camillo Bruni, 2015-12-22 08:57:19]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1543803002/ by cbruni@chromium.org.

The reason for reverting is: needs --allow-natives-syntax.

[Camillo Bruni, 2015-12-22 13:14:23]

Patchset #7 (id:120001) has been deleted

[Camillo Bruni, 2015-12-22 13:16:06]

Description was changed from

==========
[proxies] Better print for proxies in d8

Function proxies would not be printed so far since they ended up in
Function.prototype.toString which only works with Function as a receiver but no
Proxy. Additionally added support for more gracefully dealing with recursive
__proto__ structures introduced by proxies.

BUG=v8:1543
LOG=n

Committed: https://crrev.com/8bfb7189a3472bc9d0820a1bd4534eaaf78ff847
Cr-Commit-Position: refs/heads/master@{#32985}
==========

to

==========
[proxies] Better print for proxies in d8

Function proxies would not be printed so far since they ended up in
Function.prototype.toString which only works with Function as a receiver but no
Proxy. Additionally added support for more gracefully dealing with recursive
__proto__ structures introduced by proxies.

drive-by-fix: use IS_PROXY if possible in .js files.

BUG=v8:1543
LOG=n

Committed: https://crrev.com/8bfb7189a3472bc9d0820a1bd4534eaaf78ff847
Cr-Commit-Position: refs/heads/master@{#32985}
==========

[Camillo Bruni, 2015-12-22 13:16:41]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2015-12-22 13:16:41]

The patchset sent to the CQ was uploaded after l-g-t-m from neis@chromium.org,
yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/1530293004/#ps140001
(title: "do not expose intrinsics directly")

[commit-bot: I haz the power, 2015-12-22 13:16:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530293004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530293004/140001

[caitp (gmail), 2015-12-22 13:21:09]

caitpotter88@gmail.com changed reviewers:
+ caitpotter88@gmail.com

[caitp (gmail), 2015-12-22 13:21:10]

https://codereview.chromium.org/1530293004/diff/140001/src/d8.js
File src/d8.js (right):

https://codereview.chromium.org/1530293004/diff/140001/src/d8.js#newcode11
src/d8.js:11: // Hacky solution to circumvent forcing --allow-natives-syntax for
d8
Why not just compile the utility script with --allow-natives-syntax in
Shell::InstallUtilityScript?

[commit-bot: I haz the power, 2015-12-22 13:49:27]

Committed patchset #7 (id:140001)

[commit-bot: I haz the power, 2015-12-22 13:50:23]

Description was changed from

==========
[proxies] Better print for proxies in d8

Function proxies would not be printed so far since they ended up in
Function.prototype.toString which only works with Function as a receiver but no
Proxy. Additionally added support for more gracefully dealing with recursive
__proto__ structures introduced by proxies.

drive-by-fix: use IS_PROXY if possible in .js files.

BUG=v8:1543
LOG=n

Committed: https://crrev.com/8bfb7189a3472bc9d0820a1bd4534eaaf78ff847
Cr-Commit-Position: refs/heads/master@{#32985}
==========

to

==========
[proxies] Better print for proxies in d8

Function proxies would not be printed so far since they ended up in
Function.prototype.toString which only works with Function as a receiver but no
Proxy. Additionally added support for more gracefully dealing with recursive
__proto__ structures introduced by proxies.

drive-by-fix: use IS_PROXY if possible in .js files.

BUG=v8:1543
LOG=n

Committed: https://crrev.com/8bfb7189a3472bc9d0820a1bd4534eaaf78ff847
Cr-Commit-Position: refs/heads/master@{#32985}

Committed: https://crrev.com/b7ff2bd5cdfdd22cbfaa510e1c42e70f4ea1d8a3
Cr-Commit-Position: refs/heads/master@{#33010}
==========

[commit-bot: I haz the power, 2015-12-22 13:50:24]

Patchset 7 (id:??) landed as
https://crrev.com/b7ff2bd5cdfdd22cbfaa510e1c42e70f4ea1d8a3
Cr-Commit-Position: refs/heads/master@{#33010}