WebRTC: Add Libfuzzer commit and trybot.

WebRTC: Add Libfuzzer commit and trybot.

The libfuzzer specific steps are similar to the ones in:
https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/recipes/chromium_libfuzzer.py

BUG=570439
TESTED=Ran all the steps locally on my Linux machine and verified
it built our libfuzzer test binary targets properly.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298063

[kjellander_chromium, 2015-12-16 21:48:57]

Description was changed from

==========
WebRTC: Add Libfuzzer commit and trybot.

BUG=570439
==========

to

==========
WebRTC: Add Libfuzzer commit and trybot.

BUG=570439
TESTED=Ran:
gn refs out/Release --all --type=executable --args="use_libfuzzer=true
is_asan=true" --as=output //webrtc/test/fuzzers:webrtc_fuzzer_main
in a WebRTC checkout and verified it returns our libfuzzer test binary targets.
==========

[kjellander_chromium, 2015-12-16 21:48:57]

kjellander@chromium.org changed reviewers:
+ pbos@chromium.org, phoglund@chromium.org

[kjellander_chromium, 2015-12-16 21:49:24]

Patchset #1 (id:1) has been deleted

[kjellander_chromium, 2015-12-16 21:50:09]

Description was changed from

==========
WebRTC: Add Libfuzzer commit and trybot.

BUG=570439
TESTED=Ran:
gn refs out/Release --all --type=executable --args="use_libfuzzer=true
is_asan=true" --as=output //webrtc/test/fuzzers:webrtc_fuzzer_main
in a WebRTC checkout and verified it returns our libfuzzer test binary targets.
==========

to

==========
WebRTC: Add Libfuzzer commit and trybot.

The libfuzzer specific steps are similar to the ones in:
https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/re...

BUG=570439
TESTED=Ran:
gn refs out/Release --all --type=executable --args="use_libfuzzer=true
is_asan=true" --as=output //webrtc/test/fuzzers:webrtc_fuzzer_main
in a WebRTC checkout and verified it returns our libfuzzer test binary targets.
==========

[kjellander_chromium, 2015-12-16 21:50:25]

Description was changed from

==========
WebRTC: Add Libfuzzer commit and trybot.

The libfuzzer specific steps are similar to the ones in:
https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/re...

BUG=570439
TESTED=Ran:
gn refs out/Release --all --type=executable --args="use_libfuzzer=true
is_asan=true" --as=output //webrtc/test/fuzzers:webrtc_fuzzer_main
in a WebRTC checkout and verified it returns our libfuzzer test binary targets.
==========

to

==========
WebRTC: Add Libfuzzer commit and trybot.

The libfuzzer specific steps are similar to the ones in:
https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/re...

BUG=570439
TESTED=Ran:
gn refs out/Release --all --type=executable --args="use_libfuzzer=true
is_asan=true" --as=output //webrtc/test/fuzzers:webrtc_fuzzer_main
in a WebRTC checkout and verified it returns our libfuzzer test binary targets.
==========

[kjellander_chromium, 2015-12-16 22:05:25]

Description was changed from

==========
WebRTC: Add Libfuzzer commit and trybot.

The libfuzzer specific steps are similar to the ones in:
https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/re...

BUG=570439
TESTED=Ran:
gn refs out/Release --all --type=executable --args="use_libfuzzer=true
is_asan=true" --as=output //webrtc/test/fuzzers:webrtc_fuzzer_main
in a WebRTC checkout and verified it returns our libfuzzer test binary targets.
==========

to

==========
WebRTC: Add Libfuzzer commit and trybot.

The libfuzzer specific steps are similar to the ones in:
https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/re...

BUG=570439
TESTED=Ran all the steps locally on my Linux machine and verified it built our
libfuzzer test binary targets properly.
==========

[kjellander_chromium, 2015-12-16 22:11:05]

Patchset #1 (id:20001) has been deleted

[kjellander_chromium, 2015-12-16 22:11:09]

Patchset #1 (id:40001) has been deleted

[kjellander_chromium, 2015-12-16 22:16:32]

Description was changed from

==========
WebRTC: Add Libfuzzer commit and trybot.

The libfuzzer specific steps are similar to the ones in:
https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/re...

BUG=570439
TESTED=Ran all the steps locally on my Linux machine and verified it built our
libfuzzer test binary targets properly.
==========

to

==========
WebRTC: Add Libfuzzer commit and trybot.

The libfuzzer specific steps are similar to the ones in:
https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/re...

BUG=570439
TESTED=Ran all the steps locally on my Linux machine and verified
it built our libfuzzer test binary targets properly.
==========

[kjellander_chromium, 2015-12-16 22:16:55]

pbos: libfuzzer specific stuff
phoglund: recipe and buildbot changes.

https://codereview.chromium.org/1530293002/diff/60001/scripts/slave/recipes/w...
File scripts/slave/recipes/webrtc/libfuzzer.py (left):

https://codereview.chromium.org/1530293002/diff/60001/scripts/slave/recipes/w...
scripts/slave/recipes/webrtc/libfuzzer.py:57: api.chromium.run_mb(mastername,
buildername, use_goma=False)
MB is a Chromium specific thing that allows dpranke@ to flip back and forth
between GYP and GN and keeps the bot configs in the source tree at
https://code.google.com/p/chromium/codesearch#chromium/src/tools/mb/mb_config...

We don't use it for WebRTC.

https://codereview.chromium.org/1530293002/diff/60001/scripts/slave/recipes/w...
File scripts/slave/recipes/webrtc/libfuzzer.py (right):

https://codereview.chromium.org/1530293002/diff/60001/scripts/slave/recipes/w...
scripts/slave/recipes/webrtc/libfuzzer.py:80: '--args="use_libfuzzer=true
is_asan=true"',
This differs from the libfuzzer recipe. It's actually strange they don't pass
use_libfuzzer=true since their fuzzers are also in a condition in
https://code.google.com/p/chromium/codesearch#chromium/src/BUILD.gn&l=737
similar to our
https://chromium.googlesource.com/external/webrtc/+/master/webrtc/BUILD.gn#283

[kjellander_chromium, 2015-12-16 22:22:08]

Cleanup redundant flags.

https://codereview.chromium.org/1530293002/diff/60001/scripts/slave/recipes/w...
File scripts/slave/recipes/webrtc/libfuzzer.py (right):

https://codereview.chromium.org/1530293002/diff/60001/scripts/slave/recipes/w...
scripts/slave/recipes/webrtc/libfuzzer.py:80: '--args="use_libfuzzer=true
is_asan=true"',
On 2015/12/16 22:16:54, kjellander (chromium) wrote:
> This differs from the libfuzzer recipe. It's actually strange they don't pass
> use_libfuzzer=true since their fuzzers are also in a condition in
> https://code.google.com/p/chromium/codesearch#chromium/src/BUILD.gn&l=737
> similar to our
> https://chromium.googlesource.com/external/webrtc/+/master/webrtc/BUILD.gn#283

Nevermind, it's actually not needed. As long as we pass these into the 'gn gen'
command, they'll be stored in out/Release/args.gn and won't need to passed in
subsequent GN calls, that's why they didn't need it.
Removed in PS#2.

[phoglund_chromium, 2015-12-17 09:05:11]

lgtm

[pbos, 2015-12-17 11:44:50]

lgtm

[kjellander_chromium, 2015-12-17 11:50:23]

The CQ bit was checked by kjellander@chromium.org

[commit-bot: I haz the power, 2015-12-17 11:50:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530293002/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530293002/70001

[commit-bot: I haz the power, 2015-12-17 11:53:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-17 11:53:17]

Try jobs failed on following builders:
  Build Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/build...)

[kjellander_chromium, 2015-12-18 13:23:27]

The CQ bit was checked by kjellander@chromium.org

[kjellander_chromium, 2015-12-18 13:23:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
phoglund@chromium.org, pbos@chromium.org
Link to the patchset: https://codereview.chromium.org/1530293002/#ps90001
(title: "Rebased")

[commit-bot: I haz the power, 2015-12-18 13:23:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1530293002/90001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1530293002/90001

[commit-bot: I haz the power, 2015-12-18 13:26:56]

Description was changed from

==========
WebRTC: Add Libfuzzer commit and trybot.

The libfuzzer specific steps are similar to the ones in:
https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/re...

BUG=570439
TESTED=Ran all the steps locally on my Linux machine and verified
it built our libfuzzer test binary targets properly.
==========

to

==========
WebRTC: Add Libfuzzer commit and trybot.

The libfuzzer specific steps are similar to the ones in:
https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/re...

BUG=570439
TESTED=Ran all the steps locally on my Linux machine and verified
it built our libfuzzer test binary targets properly.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298063
==========

[commit-bot: I haz the power, 2015-12-18 13:26:56]

Committed patchset #3 (id:90001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298063