Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1530233005:
Add visualbench as valid target to Makefile (Closed)
|
Created:
5 years ago by joshua.litt Modified:
5 years ago CC:
reviews_skia.org Base URL:
https://skia.googlesource.com/skia.git@master Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionAdd visualbench as valid target to Makefile
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1530233005
Committed: https://skia.googlesource.com/skia/+/13221b83663778a2f5cbd90e51e253268755877e
Committed: https://skia.googlesource.com/skia/+/31d46df1b0adf230c58b59c918d2d2ba64adf1ad
Patch Set 1 #Patch Set 2 : tabs = spaces #Messages
Total messages: 21 (11 generated)
Description was changed from ========== Add visualbench as valid target to Makefile BUG=skia: ========== to ========== Add visualbench as valid target to Makefile BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
joshualitt@google.com changed reviewers: + borenet@google.com, joshualitt@google.com
LGTM. Triggered a trybot to make sure.
On 2015/12/18 14:54:02, borenet wrote: > LGTM. Triggered a trybot to make sure. Actually no, it's not listed on rietveld yet. Carry on.
The CQ bit was checked by joshualitt@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530233005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530233005/20001
The CQ bit was unchecked by joshualitt@google.com
The CQ bit was checked by joshualitt@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530233005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530233005/20001
The CQ bit was unchecked by joshualitt@google.com
The CQ bit was checked by joshualitt@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530233005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530233005/20001
Message was sent while issue was closed.
Description was changed from ========== Add visualbench as valid target to Makefile BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Add visualbench as valid target to Makefile BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/13221b83663778a2f5cbd90e51e253268755877e ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/13221b83663778a2f5cbd90e51e253268755877e
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1537903003/ by joshualitt@google.com. The reason for reverting is: might be breaking cmakebot.
Message was sent while issue was closed.
Description was changed from ========== Add visualbench as valid target to Makefile BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/13221b83663778a2f5cbd90e51e253268755877e ========== to ========== Add visualbench as valid target to Makefile BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/13221b83663778a2f5cbd90e51e253268755877e ==========
The CQ bit was checked by joshualitt@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1530233005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1530233005/20001
Message was sent while issue was closed.
Description was changed from ========== Add visualbench as valid target to Makefile BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/13221b83663778a2f5cbd90e51e253268755877e ========== to ========== Add visualbench as valid target to Makefile BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/13221b83663778a2f5cbd90e51e253268755877e Committed: https://skia.googlesource.com/skia/+/31d46df1b0adf230c58b59c918d2d2ba64adf1ad ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/31d46df1b0adf230c58b59c918d2d2ba64adf1ad |
